From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbbIHXdA (ORCPT ); Tue, 8 Sep 2015 19:33:00 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:57698 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbbIHXc7 (ORCPT ); Tue, 8 Sep 2015 19:32:59 -0400 X-Helo: d03dlp03.boulder.ibm.com X-MailFrom: paulmck@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 8 Sep 2015 16:32:51 -0700 From: "Paul E. McKenney" To: Oleg Nesterov Cc: Daniel Wagner , linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, bobby.prani@gmail.com Subject: Re: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU checks Message-ID: <20150908233251.GC4029@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20150829032643.GA19166@linux.vnet.ibm.com> <1440819361-20251-1-git-send-email-paulmck@linux.vnet.ibm.com> <1440819361-20251-3-git-send-email-paulmck@linux.vnet.ibm.com> <55ED5294.1040009@monom.org> <20150907125247.GA862@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150907125247.GA862@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15090823-0021-0000-0000-00001297CAF0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 02:52:47PM +0200, Oleg Nesterov wrote: > On 09/07, Daniel Wagner wrote: > > > > On 08/29/2015 05:35 AM, Paul E. McKenney wrote: > > > +extern bool __rcu_sync_is_idle(struct rcu_sync *); > > > + > > > /** > > > * rcu_sync_is_idle() - Are readers permitted to use their fastpaths? > > > * @rsp: Pointer to rcu_sync structure to use for synchronization > > > @@ -50,7 +52,11 @@ struct rcu_sync { > > > */ > > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) > > > { > > > +#ifdef CONFIG_PROVE_RCU > > > + return __rcu_sync_is_idle(rss); > > > > s/rss/rsp? > > Hmm, yes. > > Paul, it seems that you renamed "rss" to "rsp" globally (I didn't even > notice this change), but forgot about this one ;) > > Should I send the patch or will you fix this yourself? I did fix it in -rcu, and a few other breakages as well. Most of them self-inflicted, as usual. However, I am holding off on this series in order to get it a bit more pre-merge testing. I expect to push this in v4.4. Thanx, Paul