From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631AbbIIDd6 (ORCPT ); Tue, 8 Sep 2015 23:33:58 -0400 Received: from mail-bn1on0132.outbound.protection.outlook.com ([157.56.110.132]:1377 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754439AbbIIDde (ORCPT ); Tue, 8 Sep 2015 23:33:34 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Wed, 9 Sep 2015 10:21:17 +0800 From: Peter Chen To: Roger Quadros CC: , , , , , , , , , , , Subject: Re: [PATCH v4 07/13] usb: otg: add OTG core Message-ID: <20150909022116.GF7802@shlinux2> References: <1440422484-4737-1-git-send-email-rogerq@ti.com> <1440422484-4737-8-git-send-email-rogerq@ti.com> <20150907012327.GG4914@shlinux2> <55ED6585.5050200@ti.com> <20150908083059.GD7802@shlinux2> <55EED3B5.5030806@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55EED3B5.5030806@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD049;1:8awRsTBooo99iQ0Qkj3nDctiaJrpAmXSf8Ry3EAGdbZMpuyKeyE9JDuvu0uf5HnDaNFHPqxh2AmlNf7aBPkRFiHsWIB9XSzUdAIHLN3lwJRDmu+rX/+YThDiqiP+GiB5K3nL5D2VsIfh8pn06e2jHtVbtGLhzHghsFWk3aKUuZd6rG3RmrFyQ7YdVSlEqP9sxFKBcIpp1ON4aMqG7GNpzpuQQ4gsgP4gYlWVPBBeUugYgyGp5FoaGOI0ieWiM4iLq2PMeEzmBE1NTMgFx14QAnp/sPZ1XBmhnAKoJ00dEwXgn1FdBEkChfKx49i4j53WekL4wOLisFb0yW0b13KPHL5PdY1rjEbUBXZrAJ61efVdePup9m/1Hzt9cqU6w5GZY95Cendapb5a0alKc8SVv10FokH6OgWXmBC+ZpiZIkw= X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(199003)(479174004)(5001960100002)(104016003)(54356999)(105606002)(50986999)(86362001)(64706001)(85426001)(4001350100001)(83506001)(189998001)(2950100001)(50466002)(106466001)(87936001)(11100500001)(46406003)(5001860100001)(62966003)(68736005)(6806004)(33716001)(5001830100001)(76176999)(77096005)(5007970100001)(47776003)(81156007)(4001540100001)(93886004)(97756001)(33656002)(23726002)(97736004)(46102003)(110136002)(77156002)(92566002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1217;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1217;2:KCw+zzoGWeL7zEKbZQwbTMGOQqNQycKlhp8vyHeNstAnC/3i0IrVRUCDCExEj3P0tv6GXvt1t8gytg/YWVurYv4uwnalr9lgjkwbJx/bmi+GGkXn3MbDG205LOvVEjrnY0OFMRQ6KNzVvK0RcdsLpQdgjMJYQMkXIsg9l4e+cJs=;3:inKPFwomz9l8jEF2Lcuc9yZUXcWVksbaGvCJWX995csjTfiqMZynB5zeio+NlfKbq4IW5DKOgLooPAIg+XxoNguscp67wcb4jQ820DoE5xgoX0P8M+gxtftYJbQtaoisn0iQBygUVfR323syrZuCZJCjgpZidYgiTRve8PTqrlgDsR8YxhkFxD4yy4I7rekQZAPfhKiCGTq9LsQkN4cW+NeICgLQjJA2p0N0zvr7cqU=;25:H0A9aPX5U6NaqJuFlP/hplGbrkBgerQNRo+2EcQB7w8o92arj3x6eA+C6lkyDSev0wphp+ENKJBLURSlRYTQ4CLRi9MpqK4GGDgvpVIf1WzULpp82jzZkE7N7E89YBkGLUNpp3y+ib1U/0BUYi2NmK+FeP3tb0TctpJuB/9iP926bwTQlKb4iKxflkM83ch4jdoghjlSKN/JaAOdDmj4+kwUOjE+dFX+SIUHynEbL1sMUZfAmyaoX3FJWfaAd+kCuBfHpL8mXTzDBiXZTxvlAA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1217; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1217;20:md0OiVpF0jFlWDMLgaxoBenSX6nR7G3u8teZPod2AAVbJkcwcIDYYrk7RxIfyOFVN0LI9KaRPWGscRu0x7HgMTjMKyoVDHLrxZkkg1v1y6sCuHpY9o0rYOPrTPlNQH81EFNlNnXMJ9LfXDpLFhXz+fP+zwGPSyp2ABNiH0i+LIo2GKwWWfBJCSZpllG6/PolWY6qc7VhlHmcZmptAvwHtLBx5DCWYOpsztON/Ugxw8t9pUxEpx+EVeuXnIALKI7qH+GHbhMJ2I2F7UQRTxPNmOnJWR2HEjSrPdDAnfqyrmQztHNkqs7OEr/xqIB1Ki0+3gYYkUPoQzo2CqmV+Ubpf7spz+2MsI34a7pzVsQj1YQ=;4:/OKylmBeYhHJpExS4VMSJhskJkKrZQtPIfF1rekfQ6YidfzGA9OoQa2TbsoNC0c0S00ddfm55vq8tucLHTdoXsH5bXvqAgkt21/W+17FQlfRVS13QKzRyamBb7wQGFlwHr55yOfQ7nLg65xoEZ5Tj6fLgWG55xWo2nq3B+JnBhwEBJQilV+qa/yQf8CQil1SFFC4ZujgUT+0oUvTSxb2bhOCmlJ/GVvRL9aDDVX7ae4C6L6dmVby1Ux1KqTFBaJIu4Anpnu9DhyRfVp1mVwV6LPnTjRTykSmsQu2Ffw0TLQ+EnDQiJWVUd4uI6kVChvR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BN3PR0301MB1217;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1217; X-Forefront-PRVS: 0694C54398 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB1217;23:lPGaGH9vWHKe3wE5RTZ1izCJlu5exi4p26e2t7y?= =?us-ascii?Q?+5txOwfzjnBn7clwqI19d70hsxRq77JpAXUnWBtJzMastw6G4dhwI4MlnsrF?= =?us-ascii?Q?RfhnQW0HwHPd+phO/fUmAZ1C1RUDnH+o6D6UgXHCmEaMaj6374RFhicr/MXU?= =?us-ascii?Q?JfWudJweya8eLAM1zNxDymhpPKn1Q1m+q/XgSqGQa4KdSt/OsZA8h9/GeFde?= =?us-ascii?Q?snC9jevkZ7G48Y0M+WMN42v+EFRuACFqmdXkiZkUh0D3g7bug9FEVpjDOXu8?= =?us-ascii?Q?obM189HcMAlM5KEqtrlSmaMa1VHeCkDsT9fVZTITtfsUyvBh63CVrZ1sTIrk?= =?us-ascii?Q?BPf0kq0436lKYdkyoq95j6iwJK+/KUReeizGoeYfKseJkXU/Hg1vXNiLD8CN?= =?us-ascii?Q?hbEcpYElCAd6mb6WeHysCuJMl/zM/P3Q71LtSX50bszsKKYwpTRddx0b7kiR?= =?us-ascii?Q?YVjTx1wj6fW2vpCU6goLjJLfvuphBc1OTOLWzeBMwOMJWuEVOXe/s3Fb/7td?= =?us-ascii?Q?JCl32RRRKYz3/pjcv3XEVhLQykRVtQEh7VJrueX6Kh7TbIZFXu57UPOEEGZi?= =?us-ascii?Q?MtzEuhrY+m8YFrP+xkzMPe+xnuYn55xOB6xT7BnvIW43c24kMkqW1BSvT/lO?= =?us-ascii?Q?r88bchJqKJyQTfrVUQHFrxY8PVEm832lKSyosYiVHxSCk7sbsissp/GTLomK?= =?us-ascii?Q?yi5S7bn1tcd2oUib2Fa2aNpU0XJoBdLELvKZZKMiCxAJCRODYq+ahc0B8sYi?= =?us-ascii?Q?bO6Zcu7xQViRF4WG82L/Q1XrStHdtV//7kN3//7j8whRyU+qxDKYk/TycaM8?= =?us-ascii?Q?urFm3ATSLFvGBzh/tdIu3kK50g1ZPvovimRRc1p6jwUHSwSIhxAEWnh3WwkV?= =?us-ascii?Q?+wt+en4nviKogk6t6butddYY8kNmjoHqjr0uGyV0+/qMEfGnoNk1rgsun3dH?= =?us-ascii?Q?vDgQPIl/HW+XlPyL7ChGgnOaNPRnlV5YcrncKKeBBBrbC2PFcp3jAtTUNIle?= =?us-ascii?Q?a4DgAt8VneR18Rr02jKCfxk3HeNR9S+Z43K0lWhEp/22JO/xaup5cNeH2asX?= =?us-ascii?Q?x1bnsQ1Zmw48fYVlzhTlVTGZ2X8yTfjFMrQ4EILAYRYOaQUI6LcHuVYUSk09?= =?us-ascii?Q?lzUZZumehqdYA4hphyOCr94geRKzAMJq+4r7HEjn9za9UdFDqmzsY1mnyxOw?= =?us-ascii?Q?TR8mwwWkI9M+Lveom7rYLiDIRP5V5XaO4zCkqB3dAivn7xmq+Hj1tl3WM0rr?= =?us-ascii?Q?/UKT57Kl/+Y2AWwVT6lU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1217;5:z3SLnYU6L84tljwoYrN6ivNTM4rvMOmek3VxgzeQVUHSGcuFy0bHam8DVTJaPImUOosqjaeZZ9rEieuXUgEQkzLyX8KfAqz3Hzes0EE4fjXngQzhMTy+QWyudSae4bjmApWekyociqGz0IaWECouDw==;24:pGcdIMq3Ku3fV0n8rn85tAnfmi88xH/FPZoq02jRxW/ilxELEP2NVNVFuH2J1aHnz02VSVpfRSZEKaV6bJk8yIObnxJscD2+x5XV58Tw1xk=;20:mO3V11o6AiDLRRR8EheLB+O+X3+UDFU4uwSYrBAA9sUTRyG3ICcT3NtdA5IlVySmPsyxe/y9F5/G9HRHdfhAZg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 03:33:31.9766 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1217 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 03:25:25PM +0300, Roger Quadros wrote: > > > On 08/09/15 11:31, Peter Chen wrote: > > On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: > >> On 07/09/15 04:23, Peter Chen wrote: > >>> On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadros wrote: > >>>> + * This is used by the USB Host stack to register the Host controller > >>>> + * to the OTG core. Host controller must not be started by the > >>>> + * caller as it is left upto the OTG state machine to do so. > >>>> + * > >>>> + * Returns: 0 on success, error value otherwise. > >>>> + */ > >>>> +int usb_otg_register_hcd(struct usb_hcd *hcd, unsigned int irqnum, > >>>> + unsigned long irqflags, struct otg_hcd_ops *ops) > >>>> +{ > >>>> + struct usb_otg *otgd; > >>>> + struct device *hcd_dev = hcd->self.controller; > >>>> + struct device *otg_dev = usb_otg_get_device(hcd_dev); > >>>> + > >>> > >>> One big problem here is: there are two designs for current (IP) driver > >>> code, one creates dedicated hcd device as roothub's parent, like dwc3. > >>> Another one doesn't do this, roothub's parent is core device (or otg device > >>> in your patch), like chipidea and dwc2. > >>> > >>> Then, otg_dev will be glue layer device for chipidea after that. > >> > >> OK. Let's add a way for the otg controller driver to provide the host and gadget > >> information to the otg core for such devices like chipidea and dwc2. > >> > > > > Roger, not only chipidea and dwc2, I think the musb uses the same > > hierarchy. If the host, device, and otg share the same register > > region, host part can't be a platform driver since we don't want > > to remap the same register region again. > > > > So, in the design, we may need to consider both situations, one > > is otg/host/device has its own register region, and host is a > > separate platform device (A), the other is three parts share the > > same register region, there is only one platform driver (B). > > > > A: > > > > IP core device > > | > > | > > |-----|-----| > > gadget host platform device > > | > > roothub > > > > B: > > > > IP core device > > | > > | > > |-----|-----| > > gadget roothub > > > > > >> This API must be called before the hcd/gadget-driver is added so that the otg > >> core knows it's linked to an OTG controller. > >> > >> Any better idea? > >> > > > > A flag stands for this hcd controller is the same with otg controller > > can be used, this flag can be stored at struct usb_otg_config. > > What if there is another architecture like so? > > C: > [Parent] > | > | > |------------------|--------------| > [OTG core] [gadget] [host] > > We need a more flexible mechanism to link the gadget and > host device to the otg core for non DT case. > > How about adding struct usb_otg parameter to usb_otg_register_hcd()? > > e.g. > int usb_otg_register_hcd(struct usb_otg *otg, struct usb_hcd *hcd, ..) > > If otg is NULL it will try DT otg-controller property or parent to > get the otg controller. How usb_otg_register_hcd get struct usb_otg, from where? > > > > > Peter > > > > P.S: I still read your code, I find not all APIs in this file are used > > in your dwc3 example. > > Which ones? The ones for registering/unregistered host/gadget are used > by hcd/udc core as part of usb_add/remove_hcd() and > udc_bind_to_driver()/usb_gadget_remove_driver() > Ok, now I understand your design, usb_create_hcd must be called before the fsm kicks off. The call flow like below: usb_otg_register->usb_create_hcd->usb_add_hcd->usb_otg_register_hcd-> usb_otg_start_host->usb_otg_add_hcd We need to make some changes to let chipidea work since usb_create_hcd is included at host->start. -- Best Regards, Peter Chen