From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbbIIO0d (ORCPT ); Wed, 9 Sep 2015 10:26:33 -0400 Received: from casper.infradead.org ([85.118.1.10]:33118 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbbIIO0O (ORCPT ); Wed, 9 Sep 2015 10:26:14 -0400 Date: Wed, 9 Sep 2015 16:26:08 +0200 From: Peter Zijlstra To: Daniel Wagner Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/8] sched/completion: convert completions to use simple wait queues Message-ID: <20150909142608.GP12596@twins.programming.kicks-ass.net> References: <1441800334-16609-1-git-send-email-daniel.wagner@bmw-carit.de> <1441800334-16609-4-git-send-email-daniel.wagner@bmw-carit.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441800334-16609-4-git-send-email-daniel.wagner@bmw-carit.de> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 02:05:29PM +0200, Daniel Wagner wrote: > @@ -50,10 +50,10 @@ void complete_all(struct completion *x) > { > unsigned long flags; > > - spin_lock_irqsave(&x->wait.lock, flags); > + raw_spin_lock_irqsave(&x->wait.lock, flags); > x->done += UINT_MAX/2; > - __wake_up_locked(&x->wait, TASK_NORMAL, 0); > - spin_unlock_irqrestore(&x->wait.lock, flags); > + swake_up_locked(&x->wait); > + raw_spin_unlock_irqrestore(&x->wait.lock, flags); > } > EXPORT_SYMBOL(complete_all); I don't think that's correct; __wake_up_locked(.nr=0) would wake all waiters, where swake_up_locked() will only wake one.