From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbbIIOhH (ORCPT ); Wed, 9 Sep 2015 10:37:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbbIIOhB (ORCPT ); Wed, 9 Sep 2015 10:37:01 -0400 Date: Wed, 9 Sep 2015 16:36:57 +0200 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org, mingo@redhat.com, eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com, adrian.hunter@intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V9 6/6] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report by --freq-perf Message-ID: <20150909143657.GD32139@krava.local> References: <1441740769-61236-1-git-send-email-kan.liang@intel.com> <1441740769-61236-7-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441740769-61236-7-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 03:32:49PM -0400, kan.liang@intel.com wrote: > From: Kan Liang > > Show frequency, CPU Utilization and percent performance for each symbol > in perf report by --freq-perf > > In sampling group, only group leader do sampling. So only need to print > group leader's freq in --group. > > --freq-perf option also implies --group. > > Here is an example. > > $ perf report --stdio --freq-perf > > Overhead FREQ MHz CPU% CORE_BUSY% > Command Shared Object Symbol > ........................................ ......... ..... .......... > ........... ................ ...................... > > 99.54% 99.54% 99.53% 99.53% 99.53% 2301 96 99 > tchain_edit tchain_edit [.] f3 > 0.20% 0.20% 0.20% 0.20% 0.20% 2301 98 99 > tchain_edit tchain_edit [.] f2 > 0.05% 0.05% 0.05% 0.05% 0.05% 2300 98 99 > tchain_edit [kernel.vmlinux] [k] read_tsc > > Signed-off-by: Kan Liang it seems ok to me, though I think it could be split into HPP__SINGLE_PRINT_FNS support and the rest.. but I prefer if Arnaldo or Namhyung could review this one thanks, jirka