From: "Clément Vuchener" <clement.vuchener@gmail.com>
To: jikos@kernel.org
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 0/1] Corsair Vengeance K90 driver
Date: Wed, 9 Sep 2015 17:03:46 +0200 [thread overview]
Message-ID: <20150909150346.GA7191@untxi.home> (raw)
In-Reply-To: <cover.1441641275.git.clement.vuchener@gmail.com>
On Mon, Sep 07, 2015 at 05:58:36PM +0200, Clément Vuchener wrote:
> I removed the k90_profile class completely. I cannot write a good enough ABI with what I know of the keyboard so I am leaving that part out of the kernel. If I change my mind in the future, it will be done in another patch.
>
> I also fixed a bug I had when unregistering the led device. Work was being scheduled after the led device was unregistered.
>
> On the name change, I kept a lot of K90 references. As far as I know, the only similar keyboard is the K60 that shares the same firmware but does not have all the special keys and backlight, and for which the hid-generic driver should be enough. The more recent RGB keyboard series uses a different protocol from what I have seen from the unofficial userspace driver (CKB from MSC).
Actually, I may have been wrong, other keyboard may share at least the incorrect HID usage code part. I will investigate more and send a new patch. I am still interested in comments on this one, especially on the choice of key codes for the programmable keys.
>
> changes in v2:
> - Removed the k90_profile class and devices
> - Renamed driver for a more generic name ("corsair" driver in hid-corsair.c)
> - Fixed led devices clean up (hang when unplugging and led state reset)
> - Added dependency on USB and LEDS_CLASS in Kconfig
>
> Clément Vuchener (1):
> Add Corsair Vengeance K90 driver
>
> Documentation/ABI/testing/sysfs-driver-hid-corsair | 15 +
> drivers/hid/Kconfig | 10 +
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-core.c | 1 +
> drivers/hid/hid-corsair.c | 555 +++++++++++++++++++++
> drivers/hid/hid-ids.h | 3 +
> 6 files changed, 585 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-corsair
> create mode 100644 drivers/hid/hid-corsair.c
>
> --
> 2.4.3
>
prev parent reply other threads:[~2015-09-09 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 15:58 [PATCH v2 0/1] Corsair Vengeance K90 driver Clément Vuchener
2015-09-07 15:59 ` [PATCH v2 1/1] Add " Clément Vuchener
2015-09-09 15:03 ` Clément Vuchener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909150346.GA7191@untxi.home \
--to=clement.vuchener@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).