From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbbIIPEH (ORCPT ); Wed, 9 Sep 2015 11:04:07 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:32841 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbIIPD6 (ORCPT ); Wed, 9 Sep 2015 11:03:58 -0400 Date: Wed, 9 Sep 2015 17:03:46 +0200 From: =?iso-8859-1?Q?Cl=E9ment?= Vuchener To: jikos@kernel.org Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2 0/1] Corsair Vengeance K90 driver Message-ID: <20150909150346.GA7191@untxi.home> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 05:58:36PM +0200, Clément Vuchener wrote: > I removed the k90_profile class completely. I cannot write a good enough ABI with what I know of the keyboard so I am leaving that part out of the kernel. If I change my mind in the future, it will be done in another patch. > > I also fixed a bug I had when unregistering the led device. Work was being scheduled after the led device was unregistered. > > On the name change, I kept a lot of K90 references. As far as I know, the only similar keyboard is the K60 that shares the same firmware but does not have all the special keys and backlight, and for which the hid-generic driver should be enough. The more recent RGB keyboard series uses a different protocol from what I have seen from the unofficial userspace driver (CKB from MSC). Actually, I may have been wrong, other keyboard may share at least the incorrect HID usage code part. I will investigate more and send a new patch. I am still interested in comments on this one, especially on the choice of key codes for the programmable keys. > > changes in v2: > - Removed the k90_profile class and devices > - Renamed driver for a more generic name ("corsair" driver in hid-corsair.c) > - Fixed led devices clean up (hang when unplugging and led state reset) > - Added dependency on USB and LEDS_CLASS in Kconfig > > Clément Vuchener (1): > Add Corsair Vengeance K90 driver > > Documentation/ABI/testing/sysfs-driver-hid-corsair | 15 + > drivers/hid/Kconfig | 10 + > drivers/hid/Makefile | 1 + > drivers/hid/hid-core.c | 1 + > drivers/hid/hid-corsair.c | 555 +++++++++++++++++++++ > drivers/hid/hid-ids.h | 3 + > 6 files changed, 585 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-corsair > create mode 100644 drivers/hid/hid-corsair.c > > -- > 2.4.3 >