From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbbIIOP3 (ORCPT ); Wed, 9 Sep 2015 10:15:29 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:57388 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbbIIOPU (ORCPT ); Wed, 9 Sep 2015 10:15:20 -0400 Date: Wed, 9 Sep 2015 16:14:59 +0200 From: Alban To: Arnd Bergmann Cc: Alban , linux-mips@linux-mips.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] MIPS: ath79: Add USB support on the TL-WR1043ND Message-ID: <20150909161459.30cf580f@avionic-0020> In-Reply-To: <3589971.cbF7muh57v@wuerfel> References: <1441120994-31476-1-git-send-email-albeu@free.fr> <3589971.cbF7muh57v@wuerfel> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Sep 2015 15:20:42 +0200 Arnd Bergmann wrote: > On Tuesday 01 September 2015 17:23:10 Alban Bedel wrote: > > > > this serie add a driver for the USB phy on the ATH79 SoCs and enable the > > USB port on the TL-WR1043ND. The phy controller is really trivial as it > > only use reset lines. > > > > Is this a common thing to have? If other PHY devices are like this, we > could instead add a simple generic PHY driver that just asserts all > its reset lines in the order as provided, rather than making this a > hardware specific driver that ends up getting copied several times. I don't know how common it is. However I agree that a simple driver that can start a clock and toggle a few GPIO and/or reset would make sense. However in the case of the ATH79 SoC some models have a reset line that is misused to force the PHY in sleep mode. Sadly this extra reset must be asserted for the PHY to work, so it wouldn't fit in such a generic design. Still we could have such a generic driver and let the ATH79 driver build on top of it. Honestly that's what I wanted to do, but getting generic drivers with DT support accepted is not easy. That's why I went with this driver, it is technically inferior but much easier to get considered for merging. Alban