From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616AbbIIQqO (ORCPT ); Wed, 9 Sep 2015 12:46:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbbIIQqL (ORCPT ); Wed, 9 Sep 2015 12:46:11 -0400 Date: Wed, 9 Sep 2015 18:43:24 +0200 From: Oleg Nesterov To: Linus Torvalds Cc: Al Viro , Eric Dumazet , Andrew Morton , Ingo Molnar , Maciej =?utf-8?Q?=C5=BBenczykowski?= , Peter Zijlstra , Thomas Gleixner , Linux Kernel Mailing List Subject: Re: [PATCH 3/3] Revert "task_work: remove fifo ordering guarantee" Message-ID: <20150909164324.GA5824@redhat.com> References: <20150908171433.GA14573@redhat.com> <20150908171452.GA14599@redhat.com> <20150909131642.GA28537@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09, Linus Torvalds wrote: > > On Wed, Sep 9, 2015 at 6:16 AM, Oleg Nesterov wrote: > > > > Again, rightly or not I believe that FIFO makes task_work_add() more useful. > > Perhaps I am wrong, so far I can only provide the artificial examples... > > I'd rather wait until somebody has a real use case. I hate adding > infrastructure for "what if.." scenarios. We're better off if we can > make do with minimal semantics (ie "there are no guarantees except > that the work will be done before returning to user space") than with > stronger semantics that people then perhaps start depending on even if > they didn't really need them. OK, I see. Thanks. At least you seem to agree with 1-2, so if Al takes these changes we can easily reconsider 3/3 later, if/when we have the new user which needs FIFO. Oleg.