From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbIIRUK (ORCPT ); Wed, 9 Sep 2015 13:20:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45060 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbbIIRUG (ORCPT ); Wed, 9 Sep 2015 13:20:06 -0400 Date: Wed, 9 Sep 2015 19:20:03 +0200 From: Andrea Arcangeli To: Michael Ellerman Cc: Bamvor Zhang Jian , linux-kernel@vger.kernel.org, Mark Brown , khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com Subject: Re: [PATCH 6/7] selftests: only compile userfaultfd for x86 and powperpc Message-ID: <20150909172003.GF10639@redhat.com> References: <1439559818-21666-1-git-send-email-bamvor.zhangjian@linaro.org> <1439559818-21666-7-git-send-email-bamvor.zhangjian@linaro.org> <1440991580.5735.4.camel@ellerman.id.au> <55EEA731.5090708@linaro.org> <1441706053.7601.9.camel@ellerman.id.au> <55EED3C9.2090007@linaro.org> <20150908143407.GA10639@redhat.com> <1441788191.4703.3.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441788191.4703.3.camel@ellerman.id.au> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 06:43:11PM +1000, Michael Ellerman wrote: > On Tue, 2015-09-08 at 16:34 +0200, Andrea Arcangeli wrote: > > > > I already had a few minor changes queued to be submitted for arm and > > ppc and a few updates to the selftest. > > > > I didn't like that you had to remember running make headers_install > > for changes like the below one to build, so I added the dependency so > > that "make" still works without having to run other commands before > > it. These aren't reviewed yet. > > > > https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=5ce2efeb91b501aa1bc7370f43732681fa9123e2 > > That's, how should I put it, fairly gross :) > > I'd really rather you didn't do that. It's really not that hard to run make > headers_install once manually is it? I agree it's fairly gross, but I don't like when "make" fails and you need to know something non-standard from documentation to make it work (ehm documentation? I don't think there is any about how to build the selftest). This is self documenting change (that works better than actual documentation) and you're free to run "make headers_install" by hand if you prefer after a git clean -d -x -f and you won't know the difference. If there's a cleaner solution that's fine, but I don't like to fallback in having to run "make headers_install" by hand :). > I think given you already have a series you should pick this up as part of > that series. It will need to be reworked slightly anyway to go on top of your > series I think. Yep I reworked and integrated it. Thanks! Andrea