Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program

Tycho Andersen
2015-09-04T20:42:14Z

Hi Alexei,

On Fri, Sep 04, 2015 at 01:27:05PM -0700, Alexei Starovoitov wrote:
> On Fri, Sep 04, 2015 at 10:04:21AM -0600, Tycho Andersen wrote:
> > This commit adds a way to dump eBPF programs. The initial implementation
> > doesn't support maps, and therefore only allows dumping seccomp ebpf
> > programs which themselves don't currently support maps.
> >
> >
> > Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
> > CC: Kees Cook <keescook@chromium.org>
> > CC: Will Drewry <wad@chromium.org>
> > CC: Oleg Nesterov <oleg@redhat.com>
> > CC: Andy Lutomirski <luto@amacapital.net>
> > CC: Pavel Emelyanov <xemul@parallels.com>
> > CC: Serge E. Hallyn <serge.hallyn@ubuntu.com>
> > CC: Alexei Starovoitov <ast@kernel.org>
> > CC: Daniel Borkmann <daniel@iogearbox.net>
> > ---
> > include/uapi/linux/bpf.h | 15 +++++++++++++++
> > kernel/bpf/syscall.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 59 insertions(+)
> >
> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > index 79b825a..c5d8dc2 100644
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -107,6 +107,13 @@ enum bpf_cmd {
> > * returns fd or negative error
> > */
> > BPF_PROG_LOAD,
> > +
> > + /* dump an existing bpf
> > + * err = bpf(BPF_PROG_DUMP, union bpf_attr *attr, u32 size)
> > + * Using attr->prog_fd, attr->dump_insn_cnt, attr->dump_insns
> > + * returns zero or negative error
> > + */
> > + BPF_PROG_DUMP,
> > };
> >
> > enum bpf_map_type {
> > @@ -160,6 +167,14 @@ union bpf_attr {
> > __aligned_u64 log_buf; /* user supplied buffer */
> > __u32 kern_version; /* checked when prog_type=kprobe */
> > };
> > +
> > + struct { /* anonymous struct used by BPF_PROG_DUMP command */
> > + __u32 prog_fd;
> > + __u32 dump_insn_cnt;
> > + __aligned_u64 dump_insns; /* user supplied buffer */
> > + __u8 gpl_compatible;
> > + __u64 prog_id; /* unique id for this prog */
> > + };
>
> my first reaction was to may be reuse existing struct used to load,
> but I guess it's actually cleaner to have a new one like you did.
> though prog_fd looks redundant and prog_id is ...

prog_fd is input here, the rest are outputs.

> > + if (put_user((u64) prog, &uattr->prog_id))
> > + goto out;
>
> .. is definitely not secure.
>
> > We export the GPL bit as well as a unique ID for the program so that
> > userspace can detect when two seccomp filters were inherited from each
> > other and clone the filter tree accordingly.
>
> you mean that in-kernel prog pointer is the same?
> I think user space can memcmp insns of programs instead?
> Are you trying to solve the case when parent has an FD for bpf program
> and child has another FD that points to the same program, and both
> doing dump and need to coordinate?

Yes, exactly. If we just do a memcmp(), two users can install the same
filter and have a different inheritance model on checkpoint vs
restore. This means that a checkpoint/restore'd process may see
different behavior when using SECCOMP_FILTER_FLAG_TSYNC in the future.

I'm not entirely clear on how much of a problem this actually is, and
perhaps it is too small to be worth worry about, but if there was
another way to export some unique id, that would be dandy.

Tycho