From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755260AbbIITw5 (ORCPT ); Wed, 9 Sep 2015 15:52:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40916 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754401AbbIITwz (ORCPT ); Wed, 9 Sep 2015 15:52:55 -0400 Date: Wed, 9 Sep 2015 11:31:37 -0700 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Lior Dotan , Christopher Harrer , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: slicoss: remove unused variables Message-ID: <20150909183137.GA7680@kroah.com> References: <1441372998-22760-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441372998-22760-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 06:53:18PM +0530, Sudip Mukherjee wrote: > These variables were only assigned some values but they were never used. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/slicoss/slicoss.c | 27 ++++++--------------------- > 1 file changed, 6 insertions(+), 21 deletions(-) > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index 8585970..1536ca0 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -199,10 +199,8 @@ static void slic_mcast_set_mask(struct adapter *adapter) > static void slic_timer_ping(ulong dev) > { > struct adapter *adapter; > - struct sliccard *card; > > adapter = netdev_priv((struct net_device *)dev); > - card = adapter->card; > > adapter->pingtimer.expires = jiffies + (PING_TIMER_INTERVAL * HZ); > add_timer(&adapter->pingtimer); > @@ -1719,7 +1717,6 @@ static u32 slic_rcvqueue_reinsert(struct adapter *adapter, struct sk_buff *skb) > */ > static void slic_link_event_handler(struct adapter *adapter) > { > - int status; > struct slic_shmem *pshmem; > > if (adapter->state != ADAPT_UP) { > @@ -1730,15 +1727,13 @@ static void slic_link_event_handler(struct adapter *adapter) > pshmem = (struct slic_shmem *)(unsigned long)adapter->phys_shmem; > > #if BITS_PER_LONG == 64 > - status = slic_upr_request(adapter, > - SLIC_UPR_RLSR, > - SLIC_GET_ADDR_LOW(&pshmem->linkstatus), > - SLIC_GET_ADDR_HIGH(&pshmem->linkstatus), > - 0, 0); > + slic_upr_request(adapter, SLIC_UPR_RLSR, > + SLIC_GET_ADDR_LOW(&pshmem->linkstatus), > + SLIC_GET_ADDR_HIGH(&pshmem->linkstatus), 0, 0); > #else > - status = slic_upr_request(adapter, SLIC_UPR_RLSR, > - (u32) &pshmem->linkstatus, /* no 4GB wrap guaranteed */ > - 0, 0, 0); > + slic_upr_request(adapter, SLIC_UPR_RLSR, > + (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */ > + 0, 0, 0); Shouldn't we do something with status instead of just ignoring it? thanks, greg k-h