From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754470AbbIJDeL (ORCPT ); Wed, 9 Sep 2015 23:34:11 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41817 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbbIJDeI (ORCPT ); Wed, 9 Sep 2015 23:34:08 -0400 Date: Wed, 9 Sep 2015 20:34:06 -0700 From: Darren Hart To: Rasmus Villemoes Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: wmi: Remove private %pUL implementation Message-ID: <20150910033406.GA107779@vmdeb7> References: <87r3qm6lvg.fsf@rasmusvillemoes.dk> <1441836525-26194-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441836525-26194-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 12:08:45AM +0200, Rasmus Villemoes wrote: > The work performed by wmi_gtoa is equivalent to simply sprintf(out, > "%pUL", in), so one could replace its body by this. However, most > users feed the result directly as a %s argument to some other function > which also understands the %p extensions (they all ultimately use > vsnprintf), so we can eliminate some stack buffers and quite a bit of > code by just using %pUL directly. > > In wmi_dev_uevent I'm not sure whether there's room for a > nul-terminator in env->buf, so I've just replaced wmi_gtoa with the > equivalent sprintf call. > > Signed-off-by: Rasmus Villemoes > --- > Resending, hoping to get it picked up this time. I appear to have dropped the ball on this, even after you sent me a reminder. My sincere apologies. I've re-reviewed, built myself, queued to testing, and it's now getting the 0-day treatment. Provided that comes back good - hopefully tonight, I'll push to for-next, and you'll see it in next in the morning, and to Linus on Friday before the close of the merge window for 4.3. -- Darren Hart Intel Open Source Technology Center