From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbbIJEkc (ORCPT ); Thu, 10 Sep 2015 00:40:32 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34325 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbIJEka (ORCPT ); Thu, 10 Sep 2015 00:40:30 -0400 Date: Thu, 10 Sep 2015 10:10:19 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Mike Rapoport , Teddy Wang , LKML Subject: Re: [PATCH v3 06/17] staging: sm750fb: rename swI2CInit to sm750_sw_i2c_init Message-ID: <20150910044019.GA32305@sudip-pc> References: <1441520287-5232-1-git-send-email-mike.rapoport@gmail.com> <1441520287-5232-7-git-send-email-mike.rapoport@gmail.com> <20150909184120.GD6604@kroah.com> <20150909200320.GA19018@zed> <20150909200704.GA9328@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150909200704.GA9328@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 01:07:04PM -0700, Greg Kroah-Hartman wrote: > On Wed, Sep 09, 2015 at 11:03:20PM +0300, Mike Rapoport wrote: > > On Wed, Sep 09, 2015 at 11:41:20AM -0700, Greg Kroah-Hartman wrote: > > > On Sun, Sep 06, 2015 at 09:17:56AM +0300, Mike Rapoport wrote: > > > > Fix the checkpatch warning about CamelCase. > > > > > > > > Signed-off-by: Mike Rapoport > > > > --- > > > > drivers/staging/sm750fb/ddk750_sii164.c | 2 +- > > > > drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- > > > > drivers/staging/sm750fb/ddk750_swi2c.h | 2 +- > > > > drivers/staging/sm750fb/sm750_hw.c | 2 +- > > > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > > > > index 3d129aa..241b77b 100644 > > > > --- a/drivers/staging/sm750fb/ddk750_sii164.c > > > > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > > > > @@ -132,7 +132,7 @@ long sii164InitChip( > > > > /* Use fast mode. */ > > > > sm750_hw_i2c_init(1); > > > > #else > > > > - swI2CInit(DEFAULT_I2C_SCL, DEFAULT_I2C_SDA); > > > > + sm750_sw_i2c_init(DEFAULT_I2C_SCL, DEFAULT_I2C_SDA); > > > > > > Hm, wait, "sw_"? what is the difference between the hw and sw versions? > > > > As far as I understood, the intention for HW is for using i2c > > controller, and SW is for using gpio bit-bang > > big-bang i2c? ick. :( Yes, there is a special version of SM750 which uses sw i2c. SM750LE is a special version which only Huawei uses. regards sudip