From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754665AbbIJNBZ (ORCPT ); Thu, 10 Sep 2015 09:01:25 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33836 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335AbbIJNBW (ORCPT ); Thu, 10 Sep 2015 09:01:22 -0400 Date: Thu, 10 Sep 2015 18:31:08 +0530 From: Sudip Mukherjee To: Mike Rapoport Cc: Greg Kroah-Hartman , Teddy Wang , LKML Subject: Re: [PATCH v3 06/17] staging: sm750fb: rename swI2CInit to sm750_sw_i2c_init Message-ID: <20150910130108.GA20249@sudip-pc> References: <1441520287-5232-1-git-send-email-mike.rapoport@gmail.com> <1441520287-5232-7-git-send-email-mike.rapoport@gmail.com> <20150909184120.GD6604@kroah.com> <20150909200320.GA19018@zed> <20150909200704.GA9328@kroah.com> <20150910044019.GA32305@sudip-pc> <20150910123958.GA5188@zed.strato> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150910123958.GA5188@zed.strato> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 03:39:58PM +0300, Mike Rapoport wrote: > Hi Sudip, > > On Thu, Sep 10, 2015 at 10:10:19AM +0530, Sudip Mukherjee wrote: > > On Wed, Sep 09, 2015 at 01:07:04PM -0700, Greg Kroah-Hartman wrote: > > > > > > > > As far as I understood, the intention for HW is for using i2c > > > > controller, and SW is for using gpio bit-bang > > > > > > big-bang i2c? ick. > > :( > > Yes, there is a special version of SM750 which uses sw i2c. > > SM750LE is a special version which only Huawei uses. > > If I'm not mistaken, device variant can be identified in run-time and > i2c implementation may be selected accordingly. Am I right? Yes, that is a possibility but I do not have this SM750LE hardware, so if anything breaks in the sw i2c while trying to unify these two i2c codes, I will not be able to test. Maybe Greg can give some idea here about how to proceed. regards sudip