From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbbIJNKm (ORCPT ); Thu, 10 Sep 2015 09:10:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33741 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbbIJNKi (ORCPT ); Thu, 10 Sep 2015 09:10:38 -0400 Date: Thu, 10 Sep 2015 15:07:50 +0200 From: Oleg Nesterov To: Ingo Molnar , Peter Zijlstra Cc: Kirill Tkhai , Srikar Dronamraju , linux-kernel@vger.kernel.org Subject: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs Message-ID: <20150910130750.GA20055@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org check_for_tasks() doesn't need to disable irqs, recursive read_lock() from interrupt is fine. While at it, s/do_each_thread/for_each_process_thread/. Signed-off-by: Oleg Nesterov --- kernel/cpu.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index 94bbe46..24551f2 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -302,8 +302,8 @@ static inline void check_for_tasks(int dead_cpu) { struct task_struct *g, *p; - read_lock_irq(&tasklist_lock); - do_each_thread(g, p) { + read_lock(&tasklist_lock); + for_each_process_thread(g, p) { if (!p->on_rq) continue; /* @@ -318,8 +318,8 @@ static inline void check_for_tasks(int dead_cpu) pr_warn("Task %s (pid=%d) is on cpu %d (state=%ld, flags=%x)\n", p->comm, task_pid_nr(p), dead_cpu, p->state, p->flags); - } while_each_thread(g, p); - read_unlock_irq(&tasklist_lock); + } + read_unlock(&tasklist_lock); } struct take_cpu_down_param { -- 1.5.5.1