From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbIJPYX (ORCPT ); Thu, 10 Sep 2015 11:24:23 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35743 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750970AbbIJPYU (ORCPT ); Thu, 10 Sep 2015 11:24:20 -0400 Date: Thu, 10 Sep 2015 17:24:15 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Josh Wu , linux-arm-kernel@lists.infradead.org, Jean-Christophe PLAGNIOL-VILLARD , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Message-ID: <20150910152415.GN3237@piout.net> References: <27620a5315a0fd314e21eac4afbfe87f1350b099.1441897573.git.nicolas.ferre@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote : > From: Josh Wu > > Correct the led labels in at91sam9n12ek. > > Signed-off-by: Josh Wu > --- > arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts > index efa75064d38a..186a1705f8d3 100644 > --- a/arch/arm/boot/dts/at91sam9n12ek.dts > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts > @@ -204,13 +204,13 @@ > }; > > d9 { > - label = "d6"; > + label = "d9"; > gpios = <&pioB 5 GPIO_ACTIVE_LOW>; > linux,default-trigger = "nand-disk"; > }; > > d10 { > - label = "d7"; > + label = "d10"; > gpios = <&pioB 6 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; The only concern being that this renaming will break userspace software assuming the LEDs are wrongly named. Is there anything that has been released by atmel that uses the wrong names (and my guess is yess and that is why there are named as such) and do you care about it? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com