From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753475AbbIJQU5 (ORCPT ); Thu, 10 Sep 2015 12:20:57 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:33068 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbbIJQUy (ORCPT ); Thu, 10 Sep 2015 12:20:54 -0400 Date: Thu, 10 Sep 2015 09:20:52 -0700 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba models Message-ID: <20150910162052.GC113820@vmdeb7> References: <1441819545-11619-1-git-send-email-coproscefalo@gmail.com> <1441819545-11619-2-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441819545-11619-2-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 11:25:45AM -0600, Azael Avalos wrote: > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function > for keymap choosing") changed the *setup_keyboard function to query for > the Hotkey Event Type to help choose the correct keymap, but turns out > that here are certain Toshiba models out there not implementing this > feature, and thus, failing to continue the input device registration and > leaving such laptops without hotkey support. > > This patch changes such check, and instead of returning an error if > the Hotkey Event Type is not present, we simply inform userspace about it, > changing the message printed from err to notice, making the function > responsible for registering the input device to continue. > > This issue was found on a Toshiba Portege Z30-B, but there might be > some other models out there affected by this regression as well. > > Cc: # 4.1+ > Signed-off-by: Azael Avalos Queued for 4.3, thanks! -- Darren Hart Intel Open Source Technology Center