From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752709AbbIJUMs (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Sep 2015 16:12:48 -0400
Received: from mail.kernel.org ([198.145.29.136]:40394 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750819AbbIJUMp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Sep 2015 16:12:45 -0400
Date: Thu, 10 Sep 2015 17:12:40 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        Borislav Petkov <bp@suse.de>, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 04/13] perf env: Introduce read_cpu_topology_map() method
Message-ID: <20150910201240.GF23511@kernel.org>
References: <1441828225-667-1-git-send-email-acme@kernel.org>
 <1441828225-667-5-git-send-email-acme@kernel.org>
 <37D7C6CF3E00A74B8858931C1DB2F07701922457@SHSMSX103.ccr.corp.intel.com>
 <20150910131250.GW3475@kernel.org>
 <37D7C6CF3E00A74B8858931C1DB2F077019228F6@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077019228F6@SHSMSX103.ccr.corp.intel.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Sep 10, 2015 at 08:00:54PM +0000, Liang, Kan escreveu:
> > Em Wed, Sep 09, 2015 at 09:41:18PM +0000, Liang, Kan escreveu:
> > > > -	for (i = 0; i < tp->cpu_nr; i++) {
> > > > -		ret = do_write(fd, &tp->core_id[i], sizeof(int));
> > > > +	perf_env__read_cpu_topology_map(&perf_env);
> > > > +

> > > I think we need to handle error here.

> > Ok, adding a test, updated patch below. While doing that, noticed that the
> > in the thread_sib case the "ret = do_something()" doesn't makes the
> > whole function fail, will fix later.

> Except patch 11 & 13 (for reverting), the rest of patches are good to me.

Ok, so, to take it more formally, can I turn this "good to me" as
justification for adding "Acked-by: Kan Liang", to those patches?

Please take a look at the other patches in the perf/env branch, I did it
while trying to figure it out if the reverts should be kept.

- Arnaldo