From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229AbbIKIZm (ORCPT ); Fri, 11 Sep 2015 04:25:42 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:32927 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbbIKIZk (ORCPT ); Fri, 11 Sep 2015 04:25:40 -0400 Date: Fri, 11 Sep 2015 13:55:36 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Pi-Cheng Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: cpufreq: mediatek: allow modular build Message-ID: <20150911082536.GL9650@linux> References: <1768766.yu1lxjsjLL@wuerfel> <20150911081753.GK9650@linux> <2329563.MhTbBXHVz1@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2329563.MhTbBXHVz1@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-09-15, 10:22, Arnd Bergmann wrote: > In my approach, I decided to allow the driver to be a module, as that > seems nicer for multi_v7_defconfig, but I now see that there are > several other drivers that can only be built-in, so if we decided to > make that the general strategy we should change them all. And we need to do that with a proper module_exit() function, otherwise we are really adding a BUG. Which you just did with your patch :) -- viresh