Re: [PATCH 13/17] thermal: int340x: allow compile test

Geert Uytterhoeven
2015-09-10T06:31:57Z

On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin <edubezval@gmail.com> wrote:
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
>
> config INT340X_THERMAL
> tristate "ACPI INT340X thermal drivers"
> - depends on X86 && ACPI
> + depends on (X86 && ACPI) || COMPILE_TEST
> select THERMAL_GOV_USER_SPACE
> select ACPI_THERMAL_REL
> select ACPI_FAN

This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
header file.

drivers/thermal/int340x_thermal/int3400_thermal.c: In function
‘int3400_thermal_get_uuids’:
drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
dereferencing pointer to incomplete type

Missing #include <linux/fs.h>

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
declaration of function ‘acpi_has_method’

Missing #include <acpi/acpi_bus.h>

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
implicit declaration of function ‘acpi_bus_get_device’

Definition depends on CONFIG_ACPI

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds