From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbbIKJ3L (ORCPT ); Fri, 11 Sep 2015 05:29:11 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37249 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbbIKJ3I (ORCPT ); Fri, 11 Sep 2015 05:29:08 -0400 Date: Fri, 11 Sep 2015 10:29:04 +0100 From: Lee Jones To: Kieran Bingham Cc: Wolfram Sang , Samuel Ortiz , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, grant.likely@linaro.org Subject: Re: [PATCH v4 8/8] mfd: as3722: Rid driver of superfluous I2C device ID structure Message-ID: <20150911092904.GL3260@x1> References: <1441823627-6227-1-git-send-email-kieranbingham@gmail.com> <1441823627-6227-9-git-send-email-kieranbingham@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1441823627-6227-9-git-send-email-kieranbingham@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2015, Kieran Bingham wrote: > From: Lee Jones > > Also remove unused second probe() parameter 'i2c_device_id'. > > Acked-by: Grant Likely > Signed-off-by: Lee Jones SoB? > --- > drivers/mfd/as3722.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mfd/as3722.c b/drivers/mfd/as3722.c > index 924ea90..6ac4be3 100644 > --- a/drivers/mfd/as3722.c > +++ b/drivers/mfd/as3722.c > @@ -354,8 +354,7 @@ static int as3722_i2c_of_probe(struct i2c_client *i2c, > return 0; > } > > -static int as3722_i2c_probe(struct i2c_client *i2c, > - const struct i2c_device_id *id) > +static int as3722_i2c_probe(struct i2c_client *i2c) > { > struct as3722 *as3722; > unsigned long irq_flags; > @@ -428,20 +427,13 @@ static const struct of_device_id as3722_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, as3722_of_match); > > -static const struct i2c_device_id as3722_i2c_id[] = { > - { "as3722", 0 }, > - {}, > -}; > -MODULE_DEVICE_TABLE(i2c, as3722_i2c_id); > - > static struct i2c_driver as3722_i2c_driver = { > .driver = { > .name = "as3722", > .of_match_table = as3722_of_match, > }, > - .probe = as3722_i2c_probe, > + .probe2 = as3722_i2c_probe, > .remove = as3722_i2c_remove, > - .id_table = as3722_i2c_id, > }; > > module_i2c_driver(as3722_i2c_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog