From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbbIKJa5 (ORCPT ); Fri, 11 Sep 2015 05:30:57 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:38736 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbIKJa4 (ORCPT ); Fri, 11 Sep 2015 05:30:56 -0400 Date: Fri, 11 Sep 2015 10:30:52 +0100 From: Lee Jones To: Kieran Bingham Cc: Wolfram Sang , Samuel Ortiz , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, grant.likely@linaro.org Subject: Re: [PATCH v4 5/8] i2c: Export i2c_match_id() for direct use by device drivers Message-ID: <20150911093052.GN3260@x1> References: <1441823627-6227-1-git-send-email-kieranbingham@gmail.com> <1441823627-6227-6-git-send-email-kieranbingham@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1441823627-6227-6-git-send-email-kieranbingham@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Sep 2015, Kieran Bingham wrote: > From: Lee Jones > > When there was no other way to match a I2C device to driver i2c_match_id() > was exclusively used. However, now there are other types of tables which > are commonly supplied, matching on an i2c_device_id table is used less > frequently. Instead of _always_ calling i2c_match_id() from within the > framework, we only need to do so from drivers which have no other way of > matching. This patch makes i2c_match_id() available to the aforementioned > device drivers. > > Acked-by: Grant Likely > Signed-off-by: Lee Jones SoB? > --- > drivers/i2c/i2c-core.c | 3 ++- > include/linux/i2c.h | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index 2ebc64d..0e40136 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -447,7 +447,7 @@ static inline int acpi_i2c_install_space_handler(struct i2c_adapter *adapter) > > /* ------------------------------------------------------------------------- */ > > -static const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id, > +const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id, > const struct i2c_client *client) > { > if (!(id && client)) > @@ -460,6 +460,7 @@ static const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id, > } > return NULL; > } > +EXPORT_SYMBOL_GPL(i2c_match_id); > > static int i2c_device_match(struct device *dev, struct device_driver *drv) > { > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 48bbbab..126585c 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -232,6 +232,8 @@ struct i2c_client { > > extern struct i2c_client *i2c_verify_client(struct device *dev); > extern struct i2c_adapter *i2c_verify_adapter(struct device *dev); > +extern const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id, > + const struct i2c_client *client); > > static inline struct i2c_client *kobj_to_i2c_client(struct kobject *kobj) > { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog