From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbbIKKZo (ORCPT ); Fri, 11 Sep 2015 06:25:44 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:52602 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbbIKKZn (ORCPT ); Fri, 11 Sep 2015 06:25:43 -0400 X-Helo: d23dlp03.au.ibm.com X-MailFrom: srikar@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 11 Sep 2015 15:54:38 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ingo Molnar , Peter Zijlstra , Kirill Tkhai , linux-kernel@vger.kernel.org Subject: Re: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs Message-ID: <20150911102438.GA7579@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150910130750.GA20055@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150910130750.GA20055@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091110-0029-0000-0000-0000022742A6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Oleg Nesterov [2015-09-10 15:07:50]: > check_for_tasks() doesn't need to disable irqs, recursive read_lock() > from interrupt is fine. > > While at it, s/do_each_thread/for_each_process_thread/. > > Signed-off-by: Oleg Nesterov Looks good to me. Reviewed-by: Srikar Dronamraju > --- > kernel/cpu.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > -- Thanks and Regards Srikar Dronamraju