From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: Allocate buffers with GFP_ATOMIC when fast_io == true
Date: Fri, 11 Sep 2015 11:28:58 +0100 [thread overview]
Message-ID: <20150911102858.GE12027@sirena.org.uk> (raw)
In-Reply-To: <1441913221-19622-1-git-send-email-sboyd@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
On Thu, Sep 10, 2015 at 12:27:01PM -0700, Stephen Boyd wrote:
> If a regmap is using fast_io, allocate buffers in the write APIs
> with GFP_ATOMIC instead of GFP_KERNEL. Otherwise we may schedule
> while atomic.
Why is this needed? If something needs fast I/O it probably doesn't
want to be going down any of the code paths that result in us doing
allocations. I'd expect either no cache, a flat cache or setting up
defaults at initialisation time.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-11 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 19:27 [PATCH] regmap: Allocate buffers with GFP_ATOMIC when fast_io == true Stephen Boyd
2015-09-11 10:28 ` Mark Brown [this message]
2015-09-11 16:16 ` Stephen Boyd
2015-09-11 17:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911102858.GE12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox