From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>,
Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] staging: wilc1000: host_interface.c: replace WILC_MALLOC with kmalloc
Date: Fri, 11 Sep 2015 16:25:57 +0530 [thread overview]
Message-ID: <20150911105557.GA16129@sudip-pc> (raw)
In-Reply-To: <1441880877-3832-2-git-send-email-mike.rapoport@gmail.com>
On Thu, Sep 10, 2015 at 01:27:53PM +0300, Mike Rapoport wrote:
> WILC_MALLOC(size) is wrapping a call to kmalloc(size, GFP_ATOMIC) with a
> check for 'size > 0', which kmalloc handles anyway
>
> The semantic patch that makes this change is as follows:
>
> @@
> expression v, s;
> type t;
> identifier i;
> @@
> (
> - v = WILC_MALLOC(s);
> + v = kmalloc(s, GFP_ATOMIC);
> |
> - t i = WILC_MALLOC(s);
> + t i = kmalloc(s, GFP_ATOMIC);
> )
>
> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> ---
Have you checked if it will be GFP_ATOMIC or GFP_KERNEL?
I think I can see many places where it will be GFP_KERNEL.
regards
sudip
next prev parent reply other threads:[~2015-09-11 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 10:27 [PATCH 0/5] staging: wilc1000: remove kmalloc wrappers Mike Rapoport
2015-09-10 10:27 ` [PATCH 1/5] staging: wilc1000: host_interface.c: replace WILC_MALLOC with kmalloc Mike Rapoport
2015-09-11 10:55 ` Sudip Mukherjee [this message]
2015-09-12 2:33 ` Greg Kroah-Hartman
2015-09-10 10:27 ` [PATCH 2/5] staging: wilc1000: wilc_wfi_cfgoperations.c: " Mike Rapoport
2015-09-10 10:27 ` [PATCH 3/5] staging: wilc1000: do not include wilc_memory.h Mike Rapoport
2015-09-10 10:27 ` [PATCH 4/5] staging: wilc1000: make: remove wilc_memory.o from wilc1000-objs Mike Rapoport
2015-09-10 10:27 ` [PATCH 5/5] staging: wilc1000: remove wilc_memory.[ch] Mike Rapoport
2015-09-12 2:34 ` [PATCH 0/5] staging: wilc1000: remove kmalloc wrappers Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911105557.GA16129@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=chris.park@atmel.com \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox