From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbbIKMt4 (ORCPT ); Fri, 11 Sep 2015 08:49:56 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35038 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbbIKMtz (ORCPT ); Fri, 11 Sep 2015 08:49:55 -0400 Date: Fri, 11 Sep 2015 18:19:45 +0530 From: Sudip Mukherjee To: Mark Brown Cc: Jarkko Nikula , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH] spi: spidev: fix possible NULL dereference Message-ID: <20150911124945.GA10016@sudip-pc> References: <1441883893-20596-1-git-send-email-sudipm.mukherjee@gmail.com> <55F2C4F4.3090704@linux.intel.com> <20150911122513.GT12027@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150911122513.GT12027@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 01:25:13PM +0100, Mark Brown wrote: > On Fri, Sep 11, 2015 at 03:11:32PM +0300, Jarkko Nikula wrote: > > > Actually this fixes a *real* NULL dereference case but it is not related to > > normal open/close life cycle of spidev. It requires that spidev is kept open > > when SPI master is removed. > > > spidev->spi is set to NULL in spidev_remove() and it is called before > > spidev_release() in case master is removed while spidev is in use > > > It would be good to update this to commit log, add a tag below and Cc > > > > > Fixes: 9169051617df ("spi: spidev: Don't mangle max_speed_hz in underlying > > spi device") > > The patch was already applied :( Applied? But usually I will receive an auto mail from you after applying. I dont think I have received any. regards sudip