From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbbIKQ1z (ORCPT ); Fri, 11 Sep 2015 12:27:55 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:38890 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbbIKQ1x (ORCPT ); Fri, 11 Sep 2015 12:27:53 -0400 Date: Fri, 11 Sep 2015 17:27:49 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, robh+dt@kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 7/9] ARM: STi: DT: STiH407: Add FDMA driver dt nodes. Message-ID: <20150911162749.GD18779@x1> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-8-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1441980871-24475-8-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Sep 2015, Peter Griffin wrote: > These nodes are required to get the fdma driver working > on STiH407 based silicon. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 51 +++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index 838b812..da07474b 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -565,5 +565,56 @@ > <&phy_port2 PHY_TYPE_USB3>; > }; > }; > + > + fdma0: fdma0-audio@8e20000 { I'm not familiar with the FDMA driver, so can't comment knowledgeably, but the part of @ should only describe the type of hardware. I believe in this case it should just be dma@08e20000. Also notice the leading zero in the address, which I believe mitigates possible confusion. Then you be more specific with the label, so something like 'fdma-audio' seems appropriate here. > + compatible = "st,stih407-fdma-mpe31"; > + reg = <0x8e20000 0x20000>; I personally find padding up to 32bits helpful in the addresses. > + interrupts = ; > + dma-channels = <16>; > + #dma-cells = <3>; > + st,fdma-id = <0>; We usually shy away from ID properties. What is it required for in this case? > + clocks = <&clk_s_c0_flexgen CLK_FDMA>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>; > + clock-names = "fdma_slim", > + "fdma_hi", > + "fdma_low", > + "fdma_ic"; > + }; > + > + fdma1: fdma1-app@8e40000 { > + compatible = "st,stih407-fdma-mpe31"; > + reg = <0x8e40000 0x20000>; > + interrupts = ; > + dma-channels = <16>; > + #dma-cells = <3>; > + st,fdma-id = <1>; > + clocks = <&clk_s_c0_flexgen CLK_FDMA>, > + <&clk_s_c0_flexgen CLK_TX_ICN_DMU>, > + <&clk_s_c0_flexgen CLK_TX_ICN_DMU>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>; > + clock-names = "fdma_slim", > + "fdma_hi", > + "fdma_low", > + "fdma_ic"; > + }; > + > + fdma2: fdma2-free_running@8e60000 { > + compatible = "st,stih407-fdma-mpe31"; > + reg = <0x8e60000 0x20000>; > + interrupts = ; > + dma-channels = <16>; > + #dma-cells = <3>; > + st,fdma-id = <2>; > + clocks = <&clk_s_c0_flexgen CLK_FDMA>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>, > + <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_EXT2F_A9>; > + clock-names = "fdma_slim", > + "fdma_hi", > + "fdma_low", > + "fdma_ic"; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog