From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbbIKREU (ORCPT ); Fri, 11 Sep 2015 13:04:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:16308 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbIKRET (ORCPT ); Fri, 11 Sep 2015 13:04:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,512,1437462000"; d="scan'208";a="803233964" Date: Fri, 11 Sep 2015 14:03:03 -0400 From: "Raj, Ashok" To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Tony Luck , Ashok Raj Subject: Re: [Patch V1] x86, mce: CPU synchronization for broadcast MCE's is surprised by offline CPUs Message-ID: <20150911180302.GA4233@otc-brkl-03.jf.intel.com> References: <1441931198-3209-1-git-send-email-ashok.raj@intel.com> <20150911084636.GB2042@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150911084636.GB2042@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris On Fri, Sep 11, 2015 at 10:46:36AM +0200, Borislav Petkov wrote: > > One more buffer for MCEs? Why? > > We did add the mce_gen_pool thing exactly for logging stuff in atomic > context. From looking at the code, we probably could get rid of that > "struct mce_log mcelog" thing too and use only the gen_pool for logging > MCEs. I think using gen_pool should be fine. Also seems the notify moved to the mce_gen_pool_process(), so there should be no notifier calls from the offline cpu. Let me take a respin and resend. I should have noticed.. apologies. > > We can then get rid of that MCE_LOG_LEN arbitrary 32 records and use > a nice 2-paged buffer which can be enlarged transparently later, if > needed.