From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546AbbILBKS (ORCPT ); Fri, 11 Sep 2015 21:10:18 -0400 Received: from mail-bl2on0112.outbound.protection.outlook.com ([65.55.169.112]:13216 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754407AbbILBKP (ORCPT ); Fri, 11 Sep 2015 21:10:15 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Fri, 11 Sep 2015 20:10:05 -0500 From: Scott Wood To: Roy Pledge CC: , , Subject: Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan Message-ID: <20150912011005.GA8796@home.buserror.net> References: <1439410497-19039-1-git-send-email-Roy.Pledge@freescale.com> <1439410497-19039-5-git-send-email-Roy.Pledge@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1439410497-19039-5-git-send-email-Roy.Pledge@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: CY1PR21CA0018.namprd21.prod.outlook.com (25.161.247.28) To BN3PR03MB1480.namprd03.prod.outlook.com (25.163.35.143) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1480;2:6LAKNmRxCYedwEXBZucHSN+OcNvediqEszypV7gn6WYCpaoPRwLMbos7fGodowI/S6mNsKsVvosZo8Iw13qslxX+CWgilHmxLN4z/vZj/nEHSnRxWiQ1MVkqmujbYpR1LvrNtH9u2UljanPSx3XRiCqQHNUtyU9ZiF4mpq2ugoQ=;3:jhbRvOK/MFxiGQ3Jr85EM8TsxUHAJl2IJSdd/NRsr8DFUzGqEHUMTM/9TD7hDMvsl3rEdplmpYeOy3knGPqbgeHpif1uHz63n4gqiBDKXa1yTcOntM1Tzzycctt7Lk3PtQjn1LMa45pMdcmJezBg8A==;25:pZ1DHzxlc+lxQxnimxUs9B1y6QlEs8IuhbaWpDbwg9cs3iNkUThYvxlRO/dzMPg5KrXPCu/5GuxSgrh6PpLPilfxy3ziI9dSacEo6ilfB7PrMflAXtCy8QH1zl4YTA57E1MTl+cJ+N/SLKHCJ5YOyF59VH+1sU70NRtpNNbJ0vwbURyt8RuKCpcnf65hLXiTYTfRedCvZC037Dd8Kb+9U5Ehiv/NsqgdU5mgDeWVwdM8aZ2osrEyN4YEmFjU8iO1BeuYTweQjkGeGfCsV6SMVg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1480;20:v1hYOBPhZ5fIGXVp9PqY49m/n4CYPGezQ2a8uG4QZB1ZNP2F3UnYPkL9wKoGJKn3StwDxAm9FmnwJT9LJWfUIEUg+rcOOm9JBnj7gY2r1dPqL3UI6Q6wpDu4ZNYMQ57r7nx7O+/JpGpFRFlmf1LAYupjLCQJkWdCJMZp85rGwwJtxoReGgfL9z5kDLyIszToGVGiKQO5fRbX3eAVBhPKmZ87vVJnsKSzFzTlgNIKCNirJD4IB2abX44kO4FMlIwBSXkpcmpeKE3+xHkAB1AsnYnhlbBS0qoeVpveTsKyttUTUuOSwJ615K3Maeraa+TJJhpeUwzRjSWiL5rF8KjW65JpwW4TlpuVY9hTghMF621yb5qL7xc7Vs2W8WIToTazkQ7VStwDXYV5rXIDI5+wsadhCZKqDm+pxYSj35zk0FvkaX57xFfQcLk/CEjporX2L5JpAueok3IG36Pf6JMcntKWFQztGczEiv47WwBYMLXoiBjc8hG8XWBqsieuy69Z;4:RQ2EeXqO+NxaIUB1mmmLI5O5WKOhwwCl0Kgaf2f1NR8QMRoC/t0w7om+D2A77waYmdtI2/2O1YqGIrLYMBHH/FlFVLvqz5Ur19ZX1X0bGZAJAKWUdMvMhqDhbZ6t7cw6YxuBGu+/Q9kFmgeNCYR3Sa6XZsh8D3fsNdOcNnEu82nk8gF4Z3t7kP9DO7YMgRNIM034M8sBYdmHRAqaD4fFCxCREC8XvCsRhZZduwv2Io3Z1UJc+fKX8hLqrDkaZqnGgCCVFOVDMI83XBSfBAb/45boxlly/Pjnb9aINh3zQSEb9UAe8LmC+sFwY/mZx2uP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; X-Forefront-PRVS: 06973FFAD3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(24454002)(5004730100002)(87976001)(42186005)(50466002)(81156007)(189998001)(83506001)(68736005)(50986999)(5007970100001)(54356999)(110136002)(77096005)(69596002)(101416001)(64706001)(76176999)(46102003)(4001350100001)(97756001)(33656002)(97736004)(4001540100001)(46406003)(5001860100001)(5001830100001)(53416004)(4001450100002)(122386002)(106356001)(47776003)(86362001)(2950100001)(62966003)(23726002)(40100003)(105586002)(92566002)(5001960100002)(77156002)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1480;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1480;23:BHiGsJdst4yjsThplbNB6QaRx5bB0VDx5IdtCrXKl?= =?us-ascii?Q?y1YB6YNoBinDVVDDdSOLATZasFdRMETQ0yHnG8q6XXes/1E6IpUVFhtiWCRe?= =?us-ascii?Q?h4dSUbEaqJCecXWnqJh88h8yjqWhZPDU8y/icgubj0K+XhjrRgnjDr6/MiKv?= =?us-ascii?Q?AXfGFF6xdM2GUF7AKMWJFs+X5IDxbRsVrf4HegddyN+1V0ZVsqtiAmoZKuCp?= =?us-ascii?Q?SZYXOQ5Qp8xYNDtb6i97ew7ne1AUN5PXiW//ecCC9OAp3clu+SvVNLzJ6rs1?= =?us-ascii?Q?W8tENbPBQNfdd+g4SqmL9PuJqplCbJIIVEiAIpPDWiEmqhzqVpqh2QmYBFHL?= =?us-ascii?Q?AyKXI8d5on3vYcVmYaWZlYNmiFmSDgNhAYj2xZK2SyTaVoTjXIpLVllqf0qV?= =?us-ascii?Q?skQhGxu9ox3lRRcqhdP6rB1KLUUEwfUegwj7bBCzyFnf0NtCoXbPDiUH8SYy?= =?us-ascii?Q?d7cBLKGYf/XVupQrr1fB3rp5W/MEiSJGudKutnimXuf2eQKurJrLtE3o3r4/?= =?us-ascii?Q?ZZVdYudbJzb7WQWN0nYo6z8KtxU6tGNhkuwvDzzrvsiT2SQFx6ul+IuRPR00?= =?us-ascii?Q?yRXf/vOk7JIpRVAPh/2MxP+F7tkWBEXIbkTw6dJeDushSH3awPwoeu8DbBvM?= =?us-ascii?Q?CaCSbpG2Mwca32T+1+zSRe80YaDrGmGCdL8YF93wTmjBKCCbsQbPPFqiIX9Z?= =?us-ascii?Q?l30aajbk33dPZdLjgYC9ftC3fw1+7ScndBiRrlXp/bt7fmzY/nV0hlBitGQv?= =?us-ascii?Q?a999+TwRWfoYcIie8l13rY1wmjuuToapPTGZsKWgjZ6fnaBBUKwbL1IlqbFN?= =?us-ascii?Q?Ip53LTR5HAmKmBTME7eqQWN+rRYMQXA2RM7Dm2+jHQUGIFzTcWKk+/vif/SC?= =?us-ascii?Q?aEE/npD4fA6OjaY/reZvj380AyT1Mc9qx/SGcTVrwJF6tJf2SIjQoLhFoBEE?= =?us-ascii?Q?nzmqXosNCUUs1b8GfsoITYx2aNSVPS0T4CNOh+WAgVPGRJGYvTE+FQZ39sY1?= =?us-ascii?Q?hARBWfFfv9qUD8NDiUR5wxZUGOF9rf03sEKtF93nQ7/RYcVgo6xU9nHY9A3q?= =?us-ascii?Q?NjPLPFPq31HR1WleG+nMq8YX5QBAKXuC0ecvMMQdeLCYhGWNmYJ0rt3ysBxA?= =?us-ascii?Q?RBLdacuiH2yeGHJgQpYj+qRM9YktJovurMvorylYK2L0JuPFHfRe4YBoNW5N?= =?us-ascii?Q?RSIM5TE5pBJ7FaulpHB18gWXKaKOojg7XwT?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1480;5:cTuVePWJ5vyBeJcxpzTmQvjynhyYuX4tQpAg67twQ8sgeQJFlggDGhdQFzsgeYfpayyupmb7kY9OIISfkR+Ym+G9p2ktquFzbUHwKMy9CaGcp/kN85Va0UeT7fu8MMwZvjXxn/PIJ/0mt3rMly4njA==;24:wUpzdtLLWGx6ECCbB0TjwlybXhIcoiGRxHtWLxBru71yqYhDMq8Ve7uVTD6sd3T9+Ae7IKUod6nrSHtNCR66qbk/oNdt1cFFI0yftYqjmco=;20:rSv5AglxoHY0nn/3JUCP6SokskigM0508LZ+Oo2nRkalYqmwLwOsihFdL+ovNohT6tpAe3MjZw3q6RA9Tug5RQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2015 01:10:11.8927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1480 X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1479;2:LTjaMBwsGTdiWZyQMIRIQAaX5AYKf2D6609QUS8cp3Gtt24APJB3wWaakfGsgWnMxZHUL3pLxnjpygDoE0htZSvjv6SbRpqCCBIU8MgE6025U6YFEa7ZpjB9mFmMH6NzbsGNn/t7QLtIZoca7k9YMrG4yL74619+06boQq1QyfU=;23:gzFfYXStBnWtVfHEBg4px0mEVOeWwWnpvssb0fjIBCx4Wa90XNqtncP43gK6ab3/FYErhVQZCZp+s51T1s4YoJD0t2B3/JBYnkn6DGUYpbfpQq6b5Y10STiPkR/DHKPXWAD1GerRUnhEn0b2L+nkz5TykvITkLLlhFMaCJpG0y5WoGbayHSCuSleQBXgBimb X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote: > +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is about > + * inter-processor locking only. Note, FQLOCK() is always called either under a > + * local_irq_save() or from interrupt context - hence there's no need for irq > + * protection (and indeed, attempting to nest irq-protection doesn't work, as > + * the "irq en/disable" machinery isn't recursive...). */ > +#define FQLOCK(fq) \ > + do { \ > + struct qman_fq *__fq478 = (fq); \ > + if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \ > + spin_lock(&__fq478->fqlock); \ > + } while (0) > +#define FQUNLOCK(fq) \ > + do { \ > + struct qman_fq *__fq478 = (fq); \ > + if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \ > + spin_unlock(&__fq478->fqlock); \ > + } while (0) > + I don't see QMAN_FQ_FLAG_LOCKED set anywhere. What is the use case? -Scott