From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbbILEfO (ORCPT ); Sat, 12 Sep 2015 00:35:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57793 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbILEfM (ORCPT ); Sat, 12 Sep 2015 00:35:12 -0400 Date: Fri, 11 Sep 2015 19:33:41 -0700 From: Greg Kroah-Hartman To: Mike Rapoport Cc: Johnny Kim , Rachel Kim , Chris Park , Tony Cho , Glen Lee , Leo Kim , LKML Subject: Re: [PATCH 1/5] staging: wilc1000: host_interface.c: replace WILC_MALLOC with kmalloc Message-ID: <20150912023341.GA32067@kroah.com> References: <1441880877-3832-1-git-send-email-mike.rapoport@gmail.com> <1441880877-3832-2-git-send-email-mike.rapoport@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441880877-3832-2-git-send-email-mike.rapoport@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 01:27:53PM +0300, Mike Rapoport wrote: > WILC_MALLOC(size) is wrapping a call to kmalloc(size, GFP_ATOMIC) with a > check for 'size > 0', which kmalloc handles anyway > > The semantic patch that makes this change is as follows: > > @@ > expression v, s; > type t; > identifier i; > @@ > ( > - v = WILC_MALLOC(s); > + v = kmalloc(s, GFP_ATOMIC); > | > - t i = WILC_MALLOC(s); > + t i = kmalloc(s, GFP_ATOMIC); > ) > > Signed-off-by: Mike Rapoport Someone sent this before you did, sorry :(