From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754594AbbILLAQ (ORCPT <rfc822;w@1wt.eu>);
	Sat, 12 Sep 2015 07:00:16 -0400
Received: from mail-wi0-f178.google.com ([209.85.212.178]:33250 "EHLO
	mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754191AbbILLAO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 12 Sep 2015 07:00:14 -0400
Date: Sat, 12 Sep 2015 12:00:11 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
        Vince Weaver <vince@deater.net>, Peter Zijlstra <peterz@infradead.org>,
        Kanaka Juvva <kanaka.d.juvva@intel.com>,
        Vikas Shivappa <vikas.shivappa@intel.com>,
        Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 2/3] perf tests: Add arch tests
Message-ID: <20150912110011.GF2796@codeblueprint.co.uk>
References: <1441479742-15402-1-git-send-email-matt@codeblueprint.co.uk>
 <1441479742-15402-3-git-send-email-matt@codeblueprint.co.uk>
 <20150907122353.GF5806@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150907122353.GF5806@krava.brq.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 07 Sep, at 02:23:53PM, Jiri Olsa wrote:
> On Sat, Sep 05, 2015 at 08:02:21PM +0100, Matt Fleming wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> > index 8cf0601d1662..a1b2265eaf55 100644
> > --- a/tools/perf/tests/builtin-test.c
> > +++ b/tools/perf/tests/builtin-test.c
> > @@ -14,10 +14,17 @@
> >  #include "parse-options.h"
> >  #include "symbol.h"
> >  
> > -static struct test {
> > -	const char *desc;
> > -	int (*func)(void);
> > -} tests[] = {
> > +#if defined(__x86_64__) || defined(__i386__)
> > +#include "arch-tests.h"
> > +#else
> > +static struct test arch_tests[] = {
> > +	{
> > +		.func = NULL,
> > +	},
> > +};
> > +#endif
> 
> this could be defined as __weak array so we dont need to have #if above

Yeah, good idea. I'll make that change.

-- 
Matt Fleming, Intel Open Source Technology Center