From: Matt Fleming <matt@codeblueprint.co.uk>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Vince Weaver <vince@deater.net>,
Peter Zijlstra <peterz@infradead.org>,
Kanaka Juvva <kanaka.d.juvva@intel.com>,
Vikas Shivappa <vikas.shivappa@intel.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 2/3] perf tests: Add arch tests
Date: Sat, 12 Sep 2015 12:04:21 +0100 [thread overview]
Message-ID: <20150912110421.GH2796@codeblueprint.co.uk> (raw)
In-Reply-To: <20150907122954.GH5806@krava.brq.redhat.com>
On Mon, 07 Sep, at 02:29:54PM, Jiri Olsa wrote:
> On Sat, Sep 05, 2015 at 08:02:21PM +0100, Matt Fleming wrote:
>
> SNIP
>
> >
> > +static struct test *tests[] = {
> > + generic_tests,
> > + arch_tests,
> > +};
> > +
> > static bool perf_test__matches(struct test *test, int curr, int argc, const char *argv[])
> > {
> > int i;
> > @@ -237,7 +229,11 @@ static int run_test(struct test *test)
> > return err;
> > }
> >
> > -#define for_each_test(t) for (t = &tests[0]; t->func; t++)
> > +static unsigned int ___j; /* This is obviously not thread-safe */
> > +
> > +#define for_each_test(t) \
> > + for (___j = 0; ___j < ARRAY_SIZE(tests); ___j++) \
> > + for (t = &tests[___j][0]; t->func; t++)
> >
>
> could you also split the change on adding support for arch_tests
> and another actually moving affected tests?
Sure that makes sense.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-09-12 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 19:02 [PATCH 0/3] perf tests: Add arch tests Matt Fleming
2015-09-05 19:02 ` [PATCH 1/3] perf tests: Introduce iterator function for tests Matt Fleming
2015-09-07 12:36 ` Jiri Olsa
2015-09-15 7:00 ` [tip:perf/core] " tip-bot for Matt Fleming
2015-09-05 19:02 ` [PATCH 2/3] perf tests: Add arch tests Matt Fleming
2015-09-07 12:23 ` Jiri Olsa
2015-09-12 11:00 ` Matt Fleming
2015-09-07 12:28 ` Jiri Olsa
2015-09-12 11:03 ` Matt Fleming
2015-09-07 12:29 ` Jiri Olsa
2015-09-12 11:04 ` Matt Fleming [this message]
2015-09-05 19:02 ` [PATCH 3/3] perf tests: Add Intel CQM test Matt Fleming
2015-09-07 12:58 ` [PATCH 0/3] perf tests: Add arch tests Jiri Olsa
2015-09-08 14:24 ` Arnaldo Carvalho de Melo
2015-09-12 10:46 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912110421.GH2796@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=kanaka.d.juvva@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vikas.shivappa@intel.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox