From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Hartmut Knaack <knaack.h@gmx.de>,
Andreas Dilger <andreas.dilger@intel.com>,
Ian Abbott <abbotti@mev.co.uk>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro
Date: Sat, 12 Sep 2015 08:49:05 -0700 [thread overview]
Message-ID: <20150912154905.GC29944@kroah.com> (raw)
In-Reply-To: <CAO393ABYMQof2s-R3E1GPS5c9OZDFN_VhidCaXS6HHULcd0zXg@mail.gmail.com>
On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote:
>
>
> On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On 10/09/15 17:32, Shraddha Barke wrote:
> > This patch replaces bit shifting on 1 with the BIT(x) macro
> >
> > This was done with coccinelle:
> > @@ int g; @@
> >
> > -(1 << g)
> > +BIT(g)
> >
> > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> Something odd happened here as this is only a small proportion of the cases
> that should be updated in this file. There's one at the bottom of the
> patch for starters!
>
>
> I didn't apply BIT(x) for mixed cases.I think I should drop this patch
> altogether but
> Greg has added it. Will it cause problems ? :(
Greg can always drop it :)
prev parent reply other threads:[~2015-09-12 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 16:32 [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro Shraddha Barke
2015-09-10 16:32 ` [PATCH 5/6] Staging: lustre: ptlrpc: " Shraddha Barke
2015-09-10 16:32 ` [PATCH 6/6] Staging: comedi: " Shraddha Barke
2015-09-12 9:47 ` [PATCH 4/6] Staging: iio: cdc: " Jonathan Cameron
[not found] ` <CAO393ABYMQof2s-R3E1GPS5c9OZDFN_VhidCaXS6HHULcd0zXg@mail.gmail.com>
2015-09-12 15:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912154905.GC29944@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=andreas.dilger@intel.com \
--cc=jic23@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox