From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbbILPtI (ORCPT ); Sat, 12 Sep 2015 11:49:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35098 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbbILPtG (ORCPT ); Sat, 12 Sep 2015 11:49:06 -0400 Date: Sat, 12 Sep 2015 08:49:05 -0700 From: Greg Kroah-Hartman To: Shraddha Barke Cc: Jonathan Cameron , Julia Lawall , Hartmut Knaack , Andreas Dilger , Ian Abbott , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro Message-ID: <20150912154905.GC29944@kroah.com> References: <1441902761-11190-1-git-send-email-shraddha.6596@gmail.com> <55F3F49D.9000201@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote: > > > On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron wrote: > > On 10/09/15 17:32, Shraddha Barke wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro > > > > This was done with coccinelle: > > @@ int g; @@ > > > > -(1 << g) > > +BIT(g) > > > > Signed-off-by: Shraddha Barke > Something odd happened here as this is only a small proportion of the cases > that should be updated in this file.  There's one at the bottom of the > patch for starters! > > > I didn't apply BIT(x) for mixed cases.I think I should drop this patch > altogether but > Greg has added it. Will it cause problems ? :( Greg can always drop it :)