public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: George Beshers <gbeshers@sgi.com>
Cc: Mike Travis <travis@sgi.com>,
	linux-kernel@vger.kernel.org, Alex Thorlton <athorlton@sgi.com>,
	Dimitri Sivanich <sivanich@sgi.com>,
	Ingo Molnar <mingo@redhat.com>, Hedi Berriche <hedi@sgi.com>,
	Russ Anderson <rja@sgi.com>
Subject: Re: [PATCH 2/2] UV: NMI: simple dump failover if kdump fails
Date: Sun, 13 Sep 2015 09:23:32 +0200	[thread overview]
Message-ID: <20150913072332.GA25871@gmail.com> (raw)
In-Reply-To: <20150913025108.9932.21520.sendpatchset@gulag2.americas.sgi.com>


* George Beshers <gbeshers@sgi.com> wrote:

>     The "dump" action now generates both the show_regs() stack trace
>     and show instruction pointer information.  Whereas the "ips"
>     action only shows instruction pointers for non-idle CPU's.  This
>     is more like an abbreviated "ps" display.
> 
>     Change printk(KERN_DEFAULT...) --> pr_info()
> 
> Signed-off-by: George Beshers <gbeshers@sgi.com>
> Signed-off-by: Mike Travis <travis@sgi.com>

That's an invalid SOB chain. Did Mike author it? Then there should be a 'From:' 
field for him. If he acks it, it should be Acked-by or Reviewed-by.

I changed it to Acked-by for now.

Thanks,

	Ingo

  reply	other threads:[~2015-09-13  7:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13  2:51 [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub_nmi George Beshers
2015-09-13  2:51 ` [PATCH 2/2] UV: NMI: simple dump failover if kdump fails George Beshers
2015-09-13  7:23   ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-04-30 13:29 [PATCH 1/2] UV: NMI: insert per_cpu accessor function on uv_hub_nmi George Beshers
2015-04-30 13:29 ` [PATCH 2/2] UV: NMI: simple dump failover if kdump fails George Beshers
2015-05-01  7:27   ` Ingo Molnar
2015-05-01 16:33     ` Mike Travis
2015-05-01 16:42       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150913072332.GA25871@gmail.com \
    --to=mingo@kernel.org \
    --cc=athorlton@sgi.com \
    --cc=gbeshers@sgi.com \
    --cc=hedi@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rja@sgi.com \
    --cc=sivanich@sgi.com \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox