From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbbIMHXh (ORCPT ); Sun, 13 Sep 2015 03:23:37 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38233 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbIMHXg (ORCPT ); Sun, 13 Sep 2015 03:23:36 -0400 Date: Sun, 13 Sep 2015 09:23:32 +0200 From: Ingo Molnar To: George Beshers Cc: Mike Travis , linux-kernel@vger.kernel.org, Alex Thorlton , Dimitri Sivanich , Ingo Molnar , Hedi Berriche , Russ Anderson Subject: Re: [PATCH 2/2] UV: NMI: simple dump failover if kdump fails Message-ID: <20150913072332.GA25871@gmail.com> References: <20150913025103.9932.11080.sendpatchset@gulag2.americas.sgi.com> <20150913025108.9932.21520.sendpatchset@gulag2.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150913025108.9932.21520.sendpatchset@gulag2.americas.sgi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * George Beshers wrote: > The "dump" action now generates both the show_regs() stack trace > and show instruction pointer information. Whereas the "ips" > action only shows instruction pointers for non-idle CPU's. This > is more like an abbreviated "ps" display. > > Change printk(KERN_DEFAULT...) --> pr_info() > > Signed-off-by: George Beshers > Signed-off-by: Mike Travis That's an invalid SOB chain. Did Mike author it? Then there should be a 'From:' field for him. If he acks it, it should be Acked-by or Reviewed-by. I changed it to Acked-by for now. Thanks, Ingo