public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anjali Menon <cse.anjalimenon@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fixed line over 80 characters long
Date: Sun, 13 Sep 2015 22:07:20 -0700	[thread overview]
Message-ID: <20150914050720.GA18049@kroah.com> (raw)
In-Reply-To: <1442141520-20868-1-git-send-email-cse.anjalimenon@gmail.com>

On Sun, Sep 13, 2015 at 04:22:00PM +0530, Anjali Menon wrote:
> This is a patch that fixes line over 80 characters coding style
> warning detected by checkpatch.pl.
> 
> WARNING: line over 80 characters
> 
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index b13318a..81c793a 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  		di.info_bdstate = dgnc_Board[brd]->dpastatus;
>  		di.info_ioport = 0;
>  		di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
> -		di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
> +		di.info_physsize = (ulong) dgnc_Board[brd]->membase
> +			- dgnc_Board[brd]->membase_end;

This looks worse than it did before, there's better ways to make this
line shorter.

thanks,

greg k-h

      reply	other threads:[~2015-09-14  5:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 10:52 [PATCH] staging: dgnc: Fixed line over 80 characters long Anjali Menon
2015-09-14  5:07 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914050720.GA18049@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cse.anjalimenon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox