From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbbINFHn (ORCPT ); Mon, 14 Sep 2015 01:07:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50028 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbbINFHV (ORCPT ); Mon, 14 Sep 2015 01:07:21 -0400 Date: Sun, 13 Sep 2015 22:07:20 -0700 From: Greg KH To: Anjali Menon Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: Fixed line over 80 characters long Message-ID: <20150914050720.GA18049@kroah.com> References: <1442141520-20868-1-git-send-email-cse.anjalimenon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442141520-20868-1-git-send-email-cse.anjalimenon@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 04:22:00PM +0530, Anjali Menon wrote: > This is a patch that fixes line over 80 characters coding style > warning detected by checkpatch.pl. > > WARNING: line over 80 characters > > Signed-off-by: Anjali Menon > --- > drivers/staging/dgnc/dgnc_mgmt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c > index b13318a..81c793a 100644 > --- a/drivers/staging/dgnc/dgnc_mgmt.c > +++ b/drivers/staging/dgnc/dgnc_mgmt.c > @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > di.info_bdstate = dgnc_Board[brd]->dpastatus; > di.info_ioport = 0; > di.info_physaddr = (ulong) dgnc_Board[brd]->membase; > - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; > + di.info_physsize = (ulong) dgnc_Board[brd]->membase > + - dgnc_Board[brd]->membase_end; This looks worse than it did before, there's better ways to make this line shorter. thanks, greg k-h