* [PATCH] staging: dgnc: Fixed line over 80 characters long
@ 2015-09-13 10:52 Anjali Menon
2015-09-14 5:07 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Anjali Menon @ 2015-09-13 10:52 UTC (permalink / raw)
To: gregkh; +Cc: lidza.louina, markh, linux-kernel, devel, Anjali Menon
This is a patch that fixes line over 80 characters coding style
warning detected by checkpatch.pl.
WARNING: line over 80 characters
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index b13318a..81c793a 100644
--- a/drivers/staging/dgnc/dgnc_mgmt.c
+++ b/drivers/staging/dgnc/dgnc_mgmt.c
@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
di.info_bdstate = dgnc_Board[brd]->dpastatus;
di.info_ioport = 0;
di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
- di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+ di.info_physsize = (ulong) dgnc_Board[brd]->membase
+ - dgnc_Board[brd]->membase_end;
if (dgnc_Board[brd]->state != BOARD_FAILED)
di.info_nports = dgnc_Board[brd]->nasync;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: dgnc: Fixed line over 80 characters long
2015-09-13 10:52 [PATCH] staging: dgnc: Fixed line over 80 characters long Anjali Menon
@ 2015-09-14 5:07 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-09-14 5:07 UTC (permalink / raw)
To: Anjali Menon; +Cc: lidza.louina, devel, linux-kernel
On Sun, Sep 13, 2015 at 04:22:00PM +0530, Anjali Menon wrote:
> This is a patch that fixes line over 80 characters coding style
> warning detected by checkpatch.pl.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index b13318a..81c793a 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> di.info_bdstate = dgnc_Board[brd]->dpastatus;
> di.info_ioport = 0;
> di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
> - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
> + di.info_physsize = (ulong) dgnc_Board[brd]->membase
> + - dgnc_Board[brd]->membase_end;
This looks worse than it did before, there's better ways to make this
line shorter.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-14 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-13 10:52 [PATCH] staging: dgnc: Fixed line over 80 characters long Anjali Menon
2015-09-14 5:07 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox