From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbbING37 (ORCPT ); Mon, 14 Sep 2015 02:29:59 -0400 Received: from mail-bl2on0145.outbound.protection.outlook.com ([65.55.169.145]:38144 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751030AbbING34 (ORCPT ); Mon, 14 Sep 2015 02:29:56 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=freescale.com; Date: Mon, 14 Sep 2015 13:17:26 +0800 From: Peter Chen To: Subbaraya Sundeep Bhatta CC: Punnaiah Choudary Kalluri , "balbi@ti.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Greg Kroah-Hartman (gregkh@linuxfoundation.org)" , "kishon@ti.com" Subject: Re: Chipidea ULPI driver Message-ID: <20150914051725.GC19504@shlinux2> References: <20150910144349.GH8982@saruman.tx.rr.com> <03CA77BA8AF6F1469AEDFBDA1322A7B749FFA9BC@XAP-PVEXMBX02.xlnx.xilinx.com> <20150911012211.GA17405@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD024;1:sRU650pFuqIrxO9sXXWSrTo2qfHlafaTat2tRu0ItrU7cygPwLISN2gNQ20Dp77DBZr8CPThMyYCVibsKnwJOODooTLnmtL1LkCbmH8CRCtWfx34D+0mf8//jAjyvLUTHzgfJ9AEu8FxGKuGa4cDkHpRyHRTnYYcnDWWCAwG+vIEC+CvnDmh54rFad/+Bv+Uh7STsN/oMJNMvbDjm1TA2cwzRKMxNO4slxfFVPzKVazuYmnDXzle7tXC0lAPvv8BOQIJ46hsdpbBQ9Cl5AJFXC8VIG0U3uPaeT69kMcJZlschsjk6jYMEcouVS0Ng7e6T0gowR63C7riNWuBshBixaGk7CHfjkNCxRJXLVJ9f8jOBjixe3PvBCc6XrN3Gw9cKQx5BSk25BqYpIzWACjvmA== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(13464003)(199003)(189002)(377454003)(5007970100001)(92566002)(11100500001)(5001860100001)(62966003)(81156007)(77096005)(105606002)(33716001)(106466001)(104016003)(2950100001)(19580405001)(68736005)(5001960100002)(97736004)(110136002)(77156002)(5001830100001)(189998001)(4001540100001)(33656002)(4001350100001)(97756001)(86362001)(76176999)(50986999)(6806004)(54356999)(69596002)(87936001)(50466002)(46406003)(23726002)(46102003)(93886004)(64706001)(83506001)(47776003)(85426001)(19580395003)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB482;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB482;2:8aFvmbinSQpVZZU/3l32QJQ8pQU8oXbM2HNdLCtwEYGrZJu9hByZ0itHQHAw6pVPZMZhCrkuOAwdyCkuaqlMY3tcA6AbYoSO0hyoMswDbAuo/kmvn5atfHXbNtKl3/vWAWAqHao+ETXlB0pn9MNr/4B3C2DQc/BbR78X4OcnykA=;3:o+yHgrpOoCrRx2+4Vc3gpuPlpK7DOoMXtqRBuMdZurSALeQqvwCE80l07Cu+rRTcgtBqS5QCuXs0YAPicxPaGMaiNMAV65wW65lDY2Py0axu5Z9PVU+afgbMA5jqGfP451MsdCe/xtVNdokwCx/H4GPJbAwoBMvYoCdjbiWujI4sVVAdZq2eIaYPP2E+Ip31pkRG4nH9Y3KgWii+dOoip3vdgnoqJxvpIYo4YKMQH6o=;25:XVUI3xftMBD4u+l1AagMPOn7DsYJcqrFf3s1QLUIGMh+RvpiKJW0cht0FG8zipRoGZt2jerPX+JLY4M6sy9n0D5W4i/xhGuN0YUCb7qcdugz6SlKSLc906wm75BFQbBsC+PRX7HgsLmg87MxPOlvPpbo1hlGLcwwW1oSrAjRo4xVOyTMxFqQ3IGCS8eAwsFjDptqch0nRCo9k88OqycpA5DajaN+L+cxf49F37ME3KHKih3I/6jQ5lfGS3vBk3IcsJfoKM4zV1409CX45fUI1w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB482; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB482;20:OsVbMDvmhi0RT8FD7kOzBj0ZUxDpiS+Tmrvr5KqZ24s6wWBOhyTfK5aduatYfgk8KP12fy6n+/A30SRj8C4yU5jYKI+q2l9rQQbeLwkH3YaX8p8JdeqZKchqb0TJQxc2jHDY5lYVzmkO3vvWJepweaqvn7hE662iqOxcSoeFI83tcaZ4Q3ZYSISHenXfxWw3uhUMIp/o0g0pCBvAPajfoP771V0us1BYze4vfHAbeehxbWGHIE55XFHGttW2FnBFKEPIcb8ms9m8INPRcq7kjgJLmPJzSESlu4IdKYSJ1AXLnnQoOhT61H9aqfl40csM3w7Bi2I2+2CID12JWUCMzSE7qP5H1Z7q53kbHHWJgKM=;4:q/m71YDE+aUafGFuhdvZde8hsKxjYWn9qeB9avZ3+55csAa+j0CyVA+1SQ3jp5R0Bk4NEFY5i0rm7J7j358i8fJMrAt6UqYzcZ4cxG1yUd1tJW/XznlApufzN0IHAG7zDc5WW0Xcdo0OxSiIqwI3o8ZOBnmN8C9qnf11SmGgB9gt/74Etdv0MPNY4JA/mr7vdpN14LdjBfB6tLcfRDDH/7mzoUOJN6VFtvm7ek0VFtJFrakFSH8vYs9e3MCCliTip6IQtpb5o9ZKGu7hmlaqHkn1bZuHLcr4atI2ghBoqTaGLme54q4+Rl3Pv3Z2Wi+i X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BL2PR03MB482;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB482; X-Forefront-PRVS: 0699FCD394 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB482;23:C4ciPWCT3cwy3UR5Ln1D1Mdvlv9szb5cUCkWD5Mh0i?= =?us-ascii?Q?HWewNQ0m5/1KCRFm/YfGzvUaOPXEtCb/OISEpz5RnyIDNx7ZC9jeydogPVlk?= =?us-ascii?Q?RmGzFiSHW99rzTnZPoT5Qa1OluFsnZ66XuUyTcmzoy0Fcc+uKSST1pJnuI5D?= =?us-ascii?Q?kYph3YBdf7c2qx0vcquaLvJ7LuxEUv0jNxHTMRijZxPuOH9XmxULrwTpza0z?= =?us-ascii?Q?n8oLz3OM2b1XasZc8fYt1YURE7odYl2Pn4So8+f145+Is0u1qilE9GHsQ3Dx?= =?us-ascii?Q?cdiQRTa89mMWLl9vRpI1lYNcvzrbSCkRPBS91cApZK0QXC7BBvjc0919PqHj?= =?us-ascii?Q?JVRFI0juYZ1xFH8AhhTmYe8lRs1+kf0ANOgnRa6HS2hE+FnIVKBgqn/lXySd?= =?us-ascii?Q?IJ2hk31o1ihyqX9SoJ5tmylrkEXqv1bu6OAM/J6QKj3ApwMm9Q4HCFQCvi5b?= =?us-ascii?Q?dODYESLKrXCYUFYzpvo8k332tg6HvPn8vNeZsXqyQPmD4sYYy9Ent47qTbSq?= =?us-ascii?Q?+gf2oF56QWscAhjEyXjhTYSyaVr+fsMcx65szoKmDhxdx06BvXcdWTePhm6I?= =?us-ascii?Q?MuLYzOTfekpD9SYa6MkONLgdIACS4g9H4l+AiQiWN4JGsfjOvjeUROxN48uw?= =?us-ascii?Q?qJR/Vy2MM8uGi2g5KEqtbaRdkZN+kog83TjzyDwI49VST2s/N36sZ52sN+jc?= =?us-ascii?Q?9kHhD+UmuBP5OcorznfAsRMK9QyM763Lkv1aCRgeo5nEX1fihwq/BoF4yVTv?= =?us-ascii?Q?iX1ufn49fD118pOOZSVT2hn0k1rqqdEQNe/QSRORBbRTfQa/HHIAv/YjF1fz?= =?us-ascii?Q?G4PAH2EJNwJhJ99yN0PTzXz/FP2ENRDGStdO/J7E00PYAVlOxmn8HKJajbi6?= =?us-ascii?Q?Hy6x65F1lzhfHX31ZrNGgTdQPUILfCpyvKGqcTJZz4Oj5Jwr1AT4Kdsrzrde?= =?us-ascii?Q?5WRhnaVhTAn/7iur7+sNfOWOJnbAnPzZNl4xrMGdPRwyWUPJgRZpE0H+t+ET?= =?us-ascii?Q?0vT29eQW67510nTXtO7N4c71Lh+W0xeEufaGwbKDsUdeaEQ2GURcwvf+aMHY?= =?us-ascii?Q?Kt/vwbY/ae3vcSaT0d2Pbq083z7UrkF1aPNxD56nCvIUW1PzvDgp9aqug/r1?= =?us-ascii?Q?YrhLVLcdrPOa3DaDariRFAOXEr7fYco1iCuIFgPhIIIm74Axul6IRlk4+/Am?= =?us-ascii?Q?2Iwts8Dy+iJdI1C0OpPQecj7NEU0/8IMPJV2KJT4sCzHB2QriHhQIOHOclJq?= =?us-ascii?Q?wF5dNJiA8sXBZYhnuCqBd1KHTS5/bsCzakL3qx1ka9soFWOgdUoz4eFCWTGo?= =?us-ascii?Q?WJMrL6OlT+u7muFaJTUbuEmqgTyXHz9vU+XOAKX+GIPP8OanEAPaJWvexY6y?= =?us-ascii?Q?fbbQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB482;5:OGRHmT3UqVIe/cRR4bPHKasp3F4pi/2yepw+ylfAFihQaWUXESuGO3aryoY0NGJHFhSnrDUVIVdXdKz224Y+4Ne8pFKWhmHIzGX4RmTNGXwjE8feQ/rhT/RkpvdzRsTJoVCQaECnZm2MWiYRXHQuUQ==;24:Opg3cHWd8ArPj4rTA2EsBiSxqOYdXP1AgHSTAbm1AWYQ1amBavaPX44J4qnN3QioWfYU3RhoPNpHndnH9cEPCLXvhe7+bv4baotrvVaaeXk=;20:fHQO4okZxd/ROkKnd9ZoP7BFB+glDPzY7XurhJgRUabfZAEYYx7u2Wevuo4mOx34Uw+i+9W7uDexkpUBzL0Etg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2015 06:29:53.6255 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 11:34:10AM +0000, Subbaraya Sundeep Bhatta wrote: > Hi, > > > -----Original Message----- > > From: Peter Chen [mailto:peter.chen@freescale.com] > > Sent: Friday, September 11, 2015 6:52 AM > > To: Punnaiah Choudary Kalluri > > Cc: balbi@ti.com; Subbaraya Sundeep Bhatta; linux-usb@vger.kernel.org; linux- > > kernel@vger.kernel.org; Greg Kroah-Hartman (gregkh@linuxfoundation.org); > > kishon@ti.com > > Subject: Re: Chipidea ULPI driver > > > > On Thu, Sep 10, 2015 at 02:57:49PM +0000, Punnaiah Choudary Kalluri wrote: > > > > > > > > > > -----Original Message----- > > > > From: Felipe Balbi [mailto:balbi@ti.com] > > > > Sent: Thursday, September 10, 2015 8:14 PM > > > > To: Subbaraya Sundeep Bhatta > > > > Cc: Peter Chen; balbi@ti.com; linux-usb@vger.kernel.org; linux- > > > > kernel@vger.kernel.org; Greg Kroah-Hartman > > > > (gregkh@linuxfoundation.org); kishon@ti.com; Punnaiah Choudary > > > > Kalluri > > > > Subject: Re: Chipidea ULPI driver > > > > > > > > (break your lines at 80-characters) > > > > > > > > On Thu, Sep 10, 2015 at 12:44:58PM +0000, Subbaraya Sundeep Bhatta > > wrote: > > > > > Hi Peter, > > > > > > > > > > We are using NOP transceiver driver for USB3320 ULPI PHY with > > > > > ChipIdea controller. > > > > > > > > > > Recently we found that one of the boards (zedboard) requires PHY > > > > > register access to set VBUS. > > > > > > > > > > Note that our local driver we had before migrating to ChipIdea > > > > > driver calls otg_ulpi_create with flags ULPI_OTG_DRVVBUS | > > > > > ULPI_OTG_DRVVBUS_EXT so that VBUS is enabled at initialization. > > > > > > > > > > Can you please let me know how to do this with ChipIdea case? I > > > > > see the following solutions: > > > > > > > > > > 1. Write ULPI driver for USB3320 similar to tusb1210. > > > > > > > > this > > > > > > How about extending the phy-ulpi driver to use it as platform driver? > > > So that boards that are using the ulpi compatible phy and driving vbus > > > from the phy can use this driver. > > > > > > > Yes, you can improve phy-ulpi driver, and it can not depend on NOP transceiver > > driver. > > AFAIK phy-ulpi.c is just exporting functions and not registering to platform > bus since it is not connected to SOC bus. I don't think we can create platform > driver for this. I have read TUSB1210 data sheet and it is similar to USB3320 > with no additional SOC bus connection and has only ULPI interface. > So it should register to ULPI bus which is in kernel recently. I will make > changes to chipidea similar to dwc3(adding ulpi.c) and write driver similar > to tusb1210.c. Is that okay? > It should be ok. -- Best Regards, Peter Chen