From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbbINHGT (ORCPT ); Mon, 14 Sep 2015 03:06:19 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36777 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbbINHGS (ORCPT ); Mon, 14 Sep 2015 03:06:18 -0400 Date: Mon, 14 Sep 2015 12:36:13 +0530 From: Viresh Kumar To: Shilpasri G Bhat Cc: rjw@rjwysocki.net, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] cpufreq : powernv: Report Pmax throttling if capped below nominal frequency Message-ID: <20150914070613.GA32551@linux> References: <1442207874-5016-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442207874-5016-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-09-15, 10:47, Shilpasri G Bhat wrote: > Log a 'critical' message if the max frequency is reduced below nominal > frequency. We already log 'info' message if the max frequency is > capped below turbo frequency. CPU should guarantee atleast nominal > frequency, but not turbo frequency in all system configurations and > environments. So report the pmax throttling with severity when Pmax is > dipped below nominal frequency. > > Signed-off-by: Shilpasri G Bhat > --- > drivers/cpufreq/powernv-cpufreq.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 64994e1..2d9ed42 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -327,8 +327,13 @@ static void powernv_cpufreq_throttle_check(void *data) > if (chips[i].throttled) > goto next; > chips[i].throttled = true; > - pr_info("CPU %d on Chip %u has Pmax reduced to %d\n", cpu, > - chips[i].id, pmsr_pmax); > + if (pmsr_pmax < powernv_pstate_info.nominal) > + pr_crit("CPU %d on Chip %u has Pmax reduced to %d\n", > + cpu, chips[i].id, pmsr_pmax); > + else > + pr_info("CPU %d on Chip %u has Pmax reduced to %d\n", > + cpu, chips[i].id, pmsr_pmax); I think the messages here can be improved a bit here to something like: pr_warn("CPU %d on Chip %u has Pmax reduced below nominal freq (%d < %d)\n", cpu, chips[i].id, pmsr_pmax, powernv_pstate_info.nominal); And similarly for the pr_info case as well. -- viresh