From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792AbbINHRf (ORCPT ); Mon, 14 Sep 2015 03:17:35 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36024 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbbINHRc (ORCPT ); Mon, 14 Sep 2015 03:17:32 -0400 Date: Mon, 14 Sep 2015 08:17:28 +0100 From: Lee Jones To: "Zha, Qipeng" Cc: "linux-kernel@vger.kernel.org" , "broonie@kernel.org" Subject: Re: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC Message-ID: <20150914071728.GA27591@x1> References: <1440519457-127907-1-git-send-email-qipeng.zha@intel.com> <20150825084650.GM19409@x1> <20150911092235.GJ3260@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Sep 2015, Zha, Qipeng wrote: > > > >> > > > >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > > > >> + [_irq] = { .reg_offset = (_off), .mask = (_mask) } > > > >> + > > > > > > >No, that's not what I asked. > > > > > > >Either this macro is going to be useful to *everyone*, or it's probably not useful to *anyone*. If it's going to exist, it should exist in the core header file, not Intel's own. > > > > > > Jones, can we keep current change as for intel's own ? not sure if Mark agree to merge this macro to core regmap header file. > > > Maybe some driver want to initialize regmap_irq structure with different/customed way. > > > Thanks. > > > Is that what Mark said when you submitted this to him? > > No, I don't get feedback from Mark. Then please at least try. Don't forget to Cc me on the patch. If Mark decides that it's not useful to others, then I will consider it for the Intel-only header. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog