From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbbINITo (ORCPT ); Mon, 14 Sep 2015 04:19:44 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38728 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbINITl (ORCPT ); Mon, 14 Sep 2015 04:19:41 -0400 Date: Mon, 14 Sep 2015 09:19:37 +0100 From: Lee Jones To: Peter Griffin Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, devicetree@vger.kernel.org, robh+dt@kernel.org, dmaengine@vger.kernel.org, Ludovic Barre Subject: Re: [PATCH v2 1/9] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Message-ID: <20150914081937.GF27591@x1> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-2-git-send-email-peter.griffin@linaro.org> <51503956.PMFrWKUjxX@wuerfel> <20150912120752.GA19897@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150912120752.GA19897@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Sep 2015, Peter Griffin wrote: > Hi Arnd, > > On Fri, 11 Sep 2015, Arnd Bergmann wrote: > > > On Friday 11 September 2015 15:14:23 Peter Griffin wrote: > > > +- st,fdma-id : Must contain fdma controller number > > > > What for? > > It is used by the driver to generate a unique firmware name. > Basically we need to know which controller instance we > are as each controller has a different firmware which needs > to be loaded. > > Rob did say that having a index type property is undesirable > over here, see my reply at the bottom > http://www.spinics.net/lists/devicetree/msg92529.html. > > However I can't think of any other useful properties we could add > to derive this information. I wouldn't use a property at all. Why not use the compatible string? Who chooses the naming scheme of the firmware binary? Is there any reason they can't be: fdma_STiH407_audio.elf fdma_STiH407_app.elf fdma_STiH407_free_running.elf Then you can have a different compatible for each: compatible = "st,stih407-fdma-mpe31-audio"; compatible = "st,stih407-fdma-mpe31-app"; compatible = "st,stih407-fdma-mpe31-free-running"; [...] > > > +Example: > > > + > > > + snd_uni_player2: snd-uni-player@2 { > > > + compatible = "st,snd_uni_player"; > > > > Maybe change the compatible string to "st,snd-uni-player"? > > Just checking the upstream driver which got merged for v4.3 > and the compatible has changed to "st,sti-uni-player" so I > can update the DT doc example to use this in v3. > > > > > The string you use here would not be acceptable for a binding. > > Presumably it is the use of "underscores" in the compatible which > is not allowed? Is that correct? Yes. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog