From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753759AbbINIoS (ORCPT ); Mon, 14 Sep 2015 04:44:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65296 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbINIoR (ORCPT ); Mon, 14 Sep 2015 04:44:17 -0400 Date: Mon, 14 Sep 2015 16:44:00 +0800 From: Dave Young To: Minfei Huang Cc: "Eric W. Biederman" , akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mhuang@redhat.com Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message Message-ID: <20150914084400.GA7953@localhost.localdomain> References: <1442128512-32578-1-git-send-email-mnfhuang@gmail.com> <87fv2il0rq.fsf@x220.int.ebiederm.org> <20150914075056.GA13324@t440s.lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150914075056.GA13324@t440s.lenovo> User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/15 at 03:50pm, Minfei Huang wrote: > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > Minfei Huang writes: > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > the kexec code. To keep the same format, add the prefix "kexec" to > > > output message. > > > > What of kexec_core? What of the messages that already have a prefix? > > > > Hi, Eric. > > Last commit(2965fa), Dave Young (dyoung@redhatcom) split the previous > kernel/kexec.c into three pieces(kexec_core.c, kexec_file.c, kexec.c). > The common functions used by both kexec and kexec_file are placed in > file kernel/kexec_core.c. > > The format of the output message likes "kexec: SYSC_kexec_load: hello, > world" previously. Due to the missing prefix "kexec", now it like > "SYSC_kexec_load: hello, world". > > Dave Young misses the Macro pr_fmt to define the prefix output message > in file kexec.c and kexec_file.c. I think the previous Macro was moved > into the file kexec_core.c when Dave did the splitting. I'm not sure it is proper to add prefix "kexec: " in all kexec*.c, so only keep it in kexec_core.c. There's already printks with prefix like "Kexec:", "crashkernel:" and other strings. Adding another prefix before them looks odd. So either remove the prefix in kexec_core, or remove other prefixes already exists in kexec*.c I would prefix to remove the "kexec:" prefix in kexec_core.c > > Thanks > Minfei > > > > Following is the format of output message now. > > > [ 140.290795] SYSC_kexec_load: hello, world > > > > > > Ideally, the format of output message likes below. > > > [ 140.291534] kexec: sanity_check_segment_list: hello, world > > > > > > Signed-off-by: Minfei Huang > > > --- > > > kernel/kexec.c | 2 ++ > > > kernel/kexec_file.c | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > > diff --git a/kernel/kexec.c b/kernel/kexec.c > > > index 4c5edc3..15351ba 100644 > > > --- a/kernel/kexec.c > > > +++ b/kernel/kexec.c > > > @@ -6,6 +6,8 @@ > > > * Version 2. See the file COPYING for more details. > > > */ > > > > > > +#define pr_fmt(fmt) "kexec: " fmt > > > + > > > #include > > > #include > > > #include > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > > index 6a9a3f2..b1ad01b 100644 > > > --- a/kernel/kexec_file.c > > > +++ b/kernel/kexec_file.c > > > @@ -9,6 +9,8 @@ > > > * Version 2. See the file COPYING for more details. > > > */ > > > > > > +#define pr_fmt(fmt) "kexec: " fmt > > > + > > > #include > > > #include > > > #include