From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755384AbbINJbl (ORCPT ); Mon, 14 Sep 2015 05:31:41 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:57681 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205AbbINJbj (ORCPT ); Mon, 14 Sep 2015 05:31:39 -0400 Date: Mon, 14 Sep 2015 10:08:16 +0100 From: Charles Keepax To: Javier Martinez Canillas CC: , Lee Jones , , Samuel Ortiz Subject: Re: [PATCH] mfd: wm831x: Fix possible NULL pointer dereference Message-ID: <20150914090816.GD11200@ck-lbox> References: <1442221676-26647-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1442221676-26647-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-14_01:2015-09-11,2015-09-13,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1509140156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2015 at 11:07:56AM +0200, Javier Martinez Canillas wrote: > The driver always checks for pdata being NULL expect in one place. > Add a check to prevent a possible NULL pointer deference error. > > Signed-off-by: Javier Martinez Canillas > > --- Acked-by: Charles Keepax Thanks, Charles