From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755329AbbINK1x (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Sep 2015 06:27:53 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:35103 "EHLO
	mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754938AbbINK1v (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Sep 2015 06:27:51 -0400
Date: Mon, 14 Sep 2015 11:27:49 +0100
From: Andy Whitcroft <apw@canonical.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: possible new false positive in checkpatch
Message-ID: <20150914102749.GR19632@bark>
References: <1442060011-3996-1-git-send-email-tal.shorer@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1442060011-3996-1-git-send-email-tal.shorer@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Sep 12, 2015 at 03:13:31PM +0300, Tal Shorer wrote:
> Since my last pull from upstream (today) , I started seeing some
> checkpatch warnings regarding suspect code indent I believe are false
> positive. Take this code for example:
> 
> static int foo(void)
> {
> 	while (bar())
> 		/* do nothing */;
> }
> 
> When running checkpath on it, the following warning is emitted:
> 
> tal@tal:~/Dev/lfs/linux|0 $ scripts/checkpatch.pl -f ~/tmp/foo.c
> WARNING: suspect code indent for conditional statements (8, 32)
> #3: FILE: /home/tal/tmp/foo.c:3:
> +	while (bar())
> +		/* do nothing */;
> 
> total: 0 errors, 1 warnings, 5 lines checked
> 
> /home/tal/tmp/foo.c has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> tal@tal:~/Dev/lfs/linux|1 $ 
> 
> Using my limited perl knowledge, I believe the lines causing this are
> 3111-3133:
> 			# remove inline comments
> 			$s =~ s/$;/ /g;
> 			$c =~ s/$;/ /g;

Yes it feels like that should be eliding them completely, and likely any
following space as well, something like this:

	$s =~ s/$;+\s*//g;
	$c =~ s/$;+\s*//g;

> Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> checkpatch: improve SUSPECT_CODE_INDENT test
> Commenting out these lines removes the warning.
> 
> This pattern exists in many places around the kernel source.
> Is this the intended behavior?

Seems wrong to me.

-apw