From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755449AbbINQ3M (ORCPT ); Mon, 14 Sep 2015 12:29:12 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:44905 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbbINQ3I (ORCPT ); Mon, 14 Sep 2015 12:29:08 -0400 X-Helo: d03dlp03.boulder.ibm.com X-MailFrom: paulmck@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 14 Sep 2015 09:28:47 -0700 From: "Paul E. McKenney" To: Oleg Nesterov Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/dev 70/71] kernel/rcu/sync.c:68:2: warning: 'deprecate_rcu_lockdep_assert' is deprecated (declared at include/linux/rcupdate.h:541) Message-ID: <20150914162847.GV4029@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <201509122015.wgq37YmO%fengguang.wu@intel.com> <20150912171703.GK4029@linux.vnet.ibm.com> <20150914155520.GA26358@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150914155520.GA26358@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091416-0033-0000-0000-000005DEAAD6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2015 at 05:55:20PM +0200, Oleg Nesterov wrote: > On 09/12, Paul E. McKenney wrote: > > > > I should have noticed this... > > Heh, me too :/ > > Thanks a lot Fengguang! > > > The new rcu_lockdep_assert() is RCU_LOCKDEP_WARN(). I am guessing > > that you would like to also make rcu_sync_lockdep_assert() be > > RCU_SYNC_LOCKDEP_WARN()? > > I am fine either way. Unless you have already fixed this in your tree, > I'd suggest the trivial fix below. I got that one, but failed to clean up the indentation. Fixed that as well. > But please let me know you want me to make another trivial change which > turns rcu_sync_lockdep_assert() into > > bool rcu_sync_read_lock_held(struct rcu_sync *rsp) > { > return gp_ops[rsp->gp_type].held(); > } > > and rcu_sync_is_idle() into > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) > { > RCU_LOCKDEP_WARN(!rcu_sync_read_lock_held(rsp), > "suspicious rcu_sync_is_idle() usage"); > return !rsp->gp_state; /* GP_IDLE */ > } There does seem to be a strong desire to move away from "assert" to "WARN", so please do! Thanx, Paul > ------------------------------------------------------------------------------- > >From 37fb0c136b979b0ef6a4ade1c7a14c8207533b2d Mon Sep 17 00:00:00 2001 > From: Oleg Nesterov > Date: Mon, 14 Sep 2015 10:54:10 -0400 > Subject: [PATCH] rcu_sync: Use RCU_LOCKDEP_WARN() rather than rcu_lockdep_assert() > > rcu_lockdep_assert() is deprecated, change rcu_sync_lockdep_assert() > to use RCU_LOCKDEP_WARN(). > > Reported-by: Fengguang Wu > Signed-off-by: Oleg Nesterov > --- > kernel/rcu/sync.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/sync.c b/kernel/rcu/sync.c > index 56ae79d..be922c9 100644 > --- a/kernel/rcu/sync.c > +++ b/kernel/rcu/sync.c > @@ -65,8 +65,8 @@ enum { CB_IDLE = 0, CB_PENDING, CB_REPLAY }; > #ifdef CONFIG_PROVE_RCU > void rcu_sync_lockdep_assert(struct rcu_sync *rsp) > { > - rcu_lockdep_assert(gp_ops[rsp->gp_type].held(), > - "suspicious rcu_sync_is_idle() usage"); > + RCU_LOCKDEP_WARN(!gp_ops[rsp->gp_type].held(), > + "suspicious rcu_sync_is_idle() usage"); > } > #endif > > -- > 2.4.3 > >