From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>
Subject: Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address
Date: Mon, 14 Sep 2015 11:35:23 -0600 [thread overview]
Message-ID: <20150914173523.GC21652@obsidianresearch.com> (raw)
In-Reply-To: <1442250923-19804-1-git-send-email-jarkko.sakkinen@linux.intel.com>
On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote:
> The command buffer address is necessarily not naturally aligned.
> The hardware drops the entire read on some platforms and fills the
> address with 1's. This patch fixes the issue by splitting the read
> into two 32 bit reads.
Is this necessary? The packed attribution means that unaligned members
are allowed and the compiler deals with it where necessary.
Jason
next prev parent reply other threads:[~2015-09-14 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 17:15 [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen
2015-09-14 17:35 ` Jason Gunthorpe [this message]
2015-09-15 10:09 ` Jarkko Sakkinen
2015-09-15 16:30 ` Jason Gunthorpe
2015-09-15 16:46 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2015-09-29 6:02 Jarkko Sakkinen
2015-09-29 6:12 ` Peter Huewe
2015-09-29 7:16 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914173523.GC21652@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox