From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Jiri Olsa" <jolsa@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"David Ahern" <dsahern@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Raphaël Beamonte" <raphael.beamonte@gmail.com>
Subject: Re: [PATCH 4/5] perf tools: Propagate error info from tp_format
Date: Mon, 14 Sep 2015 18:02:38 -0300 [thread overview]
Message-ID: <20150914210238.GH5250@kernel.org> (raw)
In-Reply-To: <20150914205303.GF5250@kernel.org>
Em Mon, Sep 14, 2015 at 05:53:03PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok continuing, found two more problems in this patch, fixed as follows,
> merging.
> - Arnaldo
> +++ b/tools/perf/tests/mmap-basic.c
> @@ -65,7 +65,7 @@ int test__basic_mmap(void)
>
> snprintf(name, sizeof(name), "sys_enter_%s", syscall_names[i]);
> evsels[i] = perf_evsel__newtp("syscalls", name);
> - if (evsels[i] == NULL) {
> + if (IS_ERR(evsels[i]) == NULL) {
modulo the == NULL ;-)
> pr_debug("perf_evsel__new\n");
> goto out_delete_evlist;
> }
next prev parent reply other threads:[~2015-09-14 21:02 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 8:38 [PATCHv2 0/5] perf tools: Enhance parsing events tracepoint error output Jiri Olsa
2015-09-07 8:38 ` [PATCH 1/5] tools: Add err.h with ERR_PTR PTR_ERR interface Jiri Olsa
2015-09-08 20:22 ` Raphaël Beamonte
2015-09-08 20:24 ` Raphaël Beamonte
2015-09-08 21:06 ` Arnaldo Carvalho de Melo
2015-09-08 21:28 ` Raphaël Beamonte
2015-09-08 21:29 ` Raphaël Beamonte
2015-09-16 7:28 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-09-21 23:41 ` Vinson Lee
2015-09-29 6:35 ` Vinson Lee
2015-09-29 7:14 ` Jiri Olsa
2015-09-29 7:20 ` Jiri Olsa
2015-09-29 7:52 ` He Kuang
2015-09-29 7:57 ` Jiri Olsa
2015-09-29 8:15 ` He Kuang
2015-09-29 10:41 ` Jiri Olsa
2015-09-29 14:52 ` Arnaldo Carvalho de Melo
2015-09-29 15:05 ` [PATCH] perf tool: Fix shadowed declaration in parse-events.c Jiri Olsa
2015-10-01 7:10 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2015-09-07 8:38 ` [PATCH 2/5] perf tools: Add tools/include into tags directories Jiri Olsa
2015-09-15 7:02 ` [tip:perf/core] perf tools: Add tools/ include " tip-bot for Jiri Olsa
2015-09-07 8:38 ` [PATCH 3/5] perf tools: Propagate error info for the tracepoint parsing Jiri Olsa
2015-09-08 21:42 ` Raphaël Beamonte
2015-09-09 7:50 ` Jiri Olsa
2015-09-12 10:54 ` Matt Fleming
2015-09-16 7:29 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-09-07 8:38 ` [PATCH 4/5] perf tools: Propagate error info from tp_format Jiri Olsa
2015-09-09 20:58 ` Arnaldo Carvalho de Melo
2015-09-10 8:24 ` Jiri Olsa
2015-09-10 14:16 ` Arnaldo Carvalho de Melo
2015-09-14 20:53 ` Arnaldo Carvalho de Melo
2015-09-14 20:59 ` Raphaël Beamonte
2015-09-14 21:36 ` Arnaldo Carvalho de Melo
2015-09-14 22:05 ` Raphaël Beamonte
2015-09-15 2:35 ` Arnaldo Carvalho de Melo
2015-09-14 21:02 ` Arnaldo Carvalho de Melo [this message]
2015-09-16 7:29 ` [tip:perf/core] perf evsel: " tip-bot for Jiri Olsa
2015-09-07 8:38 ` [PATCH 5/5] perf tools: Enhance parsing events tracepoint error output Jiri Olsa
2015-09-10 7:00 ` Namhyung Kim
2015-09-10 8:05 ` Jiri Olsa
2015-09-11 16:09 ` Namhyung Kim
2015-09-11 16:16 ` Jiri Olsa
2015-09-11 17:50 ` Raphaël Beamonte
2015-09-11 18:55 ` Arnaldo Carvalho de Melo
2015-09-11 19:56 ` Raphaël Beamonte
2015-09-11 20:22 ` Arnaldo Carvalho de Melo
2015-09-11 22:01 ` Raphaël Beamonte
2015-09-14 20:59 ` Arnaldo Carvalho de Melo
2015-09-16 7:29 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914210238.GH5250@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=raphael.beamonte@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).