From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752183AbbINVCq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Sep 2015 17:02:46 -0400
Received: from mail.kernel.org ([198.145.29.136]:51468 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750951AbbINVCp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Sep 2015 17:02:45 -0400
Date: Mon, 14 Sep 2015 18:02:38 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        =?iso-8859-1?Q?Rapha=EBl?= Beamonte <raphael.beamonte@gmail.com>
Subject: Re: [PATCH 4/5] perf tools: Propagate error info from tp_format
Message-ID: <20150914210238.GH5250@kernel.org>
References: <1441615087-13886-1-git-send-email-jolsa@kernel.org>
 <1441615087-13886-5-git-send-email-jolsa@kernel.org>
 <20150909205813.GV3475@kernel.org>
 <20150910082452.GC19014@krava.brq.redhat.com>
 <20150914205303.GF5250@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150914205303.GF5250@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Sep 14, 2015 at 05:53:03PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok continuing, found two more problems in this patch, fixed as follows,
> merging.
 
> - Arnaldo
 
> +++ b/tools/perf/tests/mmap-basic.c
> @@ -65,7 +65,7 @@ int test__basic_mmap(void)
>  
>  		snprintf(name, sizeof(name), "sys_enter_%s", syscall_names[i]);
>  		evsels[i] = perf_evsel__newtp("syscalls", name);
> -		if (evsels[i] == NULL) {
> +		if (IS_ERR(evsels[i]) == NULL) {

modulo the == NULL ;-)

>  			pr_debug("perf_evsel__new\n");
>  			goto out_delete_evlist;
>  		}